Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opening entries showing up incorrectly in TB report #36135

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

deepeshgarg007
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 14, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #36135 (fed2533) into develop (dab9688) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36135      +/-   ##
===========================================
- Coverage    64.25%   64.25%   -0.01%     
===========================================
  Files          785      785              
  Lines        60708    60707       -1     
===========================================
- Hits         39009    39008       -1     
  Misses       21699    21699              
Impacted Files Coverage Δ
erpnext/accounts/report/financial_statements.py 31.07% <ø> (+0.11%) ⬆️
...ext/accounts/report/trial_balance/trial_balance.py 0.00% <0.00%> (ø)
...ctype/accounting_dimension/accounting_dimension.py 63.97% <25.00%> (ø)

... and 1 file with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit 297c7e8 into frappe:develop Jul 14, 2023
12 checks passed
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
* fix: Opening entries showing up incorrectly in TB report

* chore: Linting Issue

(cherry picked from commit 297c7e8)
deepeshgarg007 added a commit that referenced this pull request Jul 14, 2023
fix: Opening entries showing up incorrectly in TB report (#36135)

* fix: Opening entries showing up incorrectly in TB report

* chore: Linting Issue

(cherry picked from commit 297c7e8)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
mergify bot added a commit that referenced this pull request Jul 14, 2023
fix: Opening entries showing up incorrectly in TB report (#36135)

* fix: Opening entries showing up incorrectly in TB report

* chore: Linting Issue

(cherry picked from commit 297c7e8)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
(cherry picked from commit d10e5e6)
deepeshgarg007 pushed a commit that referenced this pull request Jul 14, 2023
fix: Opening entries showing up incorrectly in TB report (#36135)

fix: Opening entries showing up incorrectly in TB report (#36135)

* fix: Opening entries showing up incorrectly in TB report

* chore: Linting Issue

(cherry picked from commit 297c7e8)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
(cherry picked from commit d10e5e6)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Jul 14, 2023
## [14.30.6](v14.30.5...v14.30.6) (2023-07-14)

### Bug Fixes

* Opening entries showing up incorrectly in TB report ([#36135](#36135)) ([8e48c4e](8e48c4e))
frappe-pr-bot pushed a commit that referenced this pull request Jul 18, 2023
# [14.31.0](v14.30.7...v14.31.0) (2023-07-18)

### Bug Fixes

* `TypeError` while creating WO from PP (backport [#36136](#36136)) ([#36137](#36137)) ([dd51010](dd51010))
* Account balance patch and query fixes ([#36117](#36117)) ([0147754](0147754))
* Accounts closing balance patch ([#36113](#36113)) ([cf29156](cf29156))
* allow manual asset receipt mov from nowhere ([#36093](#36093)) ([4aaa1a1](4aaa1a1))
* Ambiguous column error while submitting stock entry ([#36058](#36058)) ([a3a052b](a3a052b))
* circular dependency during reposting causing timeout error ([2c21404](2c21404))
* get_dimension with_cost_center_and_project=false is not working ([#35974](#35974)) ([42c93a1](42c93a1))
* Handle multi-company in patch ([#36127](#36127)) ([e7f5754](e7f5754))
* improve "Update Items" modal ([#36105](#36105)) ([b86571d](b86571d))
* incorrect Balance Qty in the stock ledger for the item with Serial and Batch no ([373b868](373b868))
* incorrect Reserved Qty for Production Plan in BIN for multi-uom case ([2f632d0](2f632d0))
* Opening balance in TB report ([#36171](#36171)) ([313ad7a](313ad7a))
* Opening entries showing up incorrectly in TB report ([#36135](#36135)) ([d10e5e6](d10e5e6))
* Remove current fiscal year from Global Defaults ([#35960](#35960)) ([b877fa6](b877fa6))
* Trailing opening entries in Accounts closing balance ([#36175](#36175)) ([8a607db](8a607db))
* validate docs in closed accounting period on save ([#36157](#36157)) ([5985e02](5985e02))

### Features

* add local holidays ([#36116](#36116)) ([94caf7f](94caf7f))
* add project filter in reports importing financial statements js file ([#36097](#36097)) ([63e26e3](63e26e3))

### Performance Improvements

* index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36144](#36144)) ([6198983](6198983))
* send SLA doctypes in boot ([adb6918](adb6918))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant