Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Opening entries showing up incorrectly in TB report #36135

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix: Opening entries showing up incorrectly in TB report #36135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e528fd8
fix: Opening entries showing up incorrectly in TB report
deepeshgarg007 Jul 14, 2023
fed2533
chore: Linting Issue
deepeshgarg007 Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion erpnext/accounts/report/financial_statements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ def set_gl_entries_by_account(
filters,
gl_entries_by_account,
ignore_closing_entries=False,
ignore_opening_entries=False,
):
"""Returns a dict like { "account": [gl entries], ... }"""
gl_entries = []
Expand All @@ -426,7 +427,6 @@ def set_gl_entries_by_account(
pluck="name",
)

ignore_opening_entries = False
if accounts_list:
# For balance sheet
if not from_date:
Expand Down
1 change: 1 addition & 0 deletions erpnext/accounts/report/trial_balance/trial_balance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ def get_data(filters):
filters,
gl_entries_by_account,
ignore_closing_entries=not flt(filters.with_period_closing_entry),
ignore_opening_entries=True,
)

calculate_values(accounts, gl_entries_by_account, opening_balances)
Expand Down