fix(Item Group): allow root deletion #36313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not possible to delete an empty, unused Item Group without any children, if it was one of possibly multiple roots of the Item Group tree. This fix allows deleting a root Item Group.
barredterra
added
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36313 +/- ##
========================================
Coverage 64.11% 64.11%
========================================
Files 785 785
Lines 60780 60779 -1
========================================
Hits 38970 38970
+ Misses 21810 21809 -1
|
deepeshgarg007
added a commit
that referenced
this pull request
Jul 27, 2023
…-36313 fix(Item Group): allow root deletion (#36313)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to delete an empty, unused Item Group without any children, if it was one of possibly multiple roots of the Item Group tree.
This is very annoying when you created Item Groups for test purposes or want to get rid of old Item Groups.
This fix allows deleting a root Item Group (if it doesn't have any children or linked records).