Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Item Group): allow root deletion (backport #36313) #36361

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 27, 2023

This is an automatic backport of pull request #36313 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

It was not possible to delete an empty, unused Item Group without any
children, if it was one of possibly multiple roots of the Item Group tree.
This fix allows deleting a root Item Group.

(cherry picked from commit fd2c272)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 27, 2023
@deepeshgarg007 deepeshgarg007 merged commit e25f4ff into version-14-hotfix Jul 27, 2023
10 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-36313 branch July 27, 2023 16:55
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants