Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't show disabled items in Item Shortage Report #36550

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: don't show disabled items in Item Shortage Report #36550

merged 1 commit into from
Aug 10, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Aug 8, 2023

fix: #36340

Before:

image

After:

image

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Aug 8, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #36550 (453970f) into develop (ecba6ee) will decrease coverage by 0.02%.
Report is 3 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #36550      +/-   ##
===========================================
- Coverage    64.65%   64.63%   -0.02%     
===========================================
  Files          789      789              
  Lines        61463    61470       +7     
===========================================
- Hits         39737    39734       -3     
- Misses       21726    21736      +10
Files Changed Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.19% <ø> (+0.03%) ⬆️
...eport/item_shortage_report/item_shortage_report.py 93.54% <ø> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.88% <100.00%> (+0.01%) ⬆️
...x_withholding_category/tax_withholding_category.py 85.49% <100.00%> (+0.16%) ⬆️
erpnext/controllers/accounts_controller.py 86.11% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

@s-aga-r s-aga-r marked this pull request as ready for review August 8, 2023 12:49
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Aug 10, 2023
@s-aga-r s-aga-r merged commit 4a7fc15 into frappe:develop Aug 10, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
@s-aga-r @mergify
fix: don't show disabled items in Item Shortage Report (#36550)
ae173c8 
(cherry picked from commit 4a7fc15)
@mergify mergify bot mentioned this pull request Aug 10, 2023
Merged
s-aga-r added a commit that referenced this pull request Aug 10, 2023
@mergify @s-aga-r
fix: don't show disabled items in Item Shortage Report (backport #3…
19cfcea 
…6550) (#36571)

fix: don't show disabled items in `Item Shortage Report` (#36550)

(cherry picked from commit 4a7fc15)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 16, 2023
@frappe-bot
chore(release): Bumped to Version 14.35.0
b773465 
# [14.35.0](v14.34.3...v14.35.0) (2023-08-16)

### Bug Fixes

* Allow backdated repayment cancels for term loans ([1377cf4](1377cf4))
* allow negative stock condition for batch item ([#36586](#36586)) ([ee04c6d](ee04c6d))
* AR/AP report based on payment terms ([#36574](#36574)) ([ac0fff7](ac0fff7))
* better remarks on Cr note created by Reconciliation ([5443592](5443592))
* Button Alignment center in hero slider ([#36607](#36607)) ([b131f70](b131f70)), closes [#36561](#36561)
* cr/dr note should be posted for exc gain/loss ([349601b](349601b))
* disallow mulitple SO with same PO No ([b901cfd](b901cfd))
* don't show disabled items in `Item Shortage Report` (backport [#36550](#36550)) ([#36571](#36571)) ([19cfcea](19cfcea))
* fetch `Stock UOM` from Item if not set (backport [#36606](#36606)) ([#36617](#36617)) ([8b13185](8b13185))
* Group Account total not showing in Financial Statements ([2912648](2912648))
* incorrect available qty for backdated stock reco with batch ([#36581](#36581)) ([2800ad3](2800ad3))
* incorrect gain/loss on allocation change on reconciliation tool ([39c439d](39c439d))
* Make default sales update frequency as monthly instead of each transaction ([4ca1f3b](4ca1f3b))
* move company rename to long queue ([8083c0b](8083c0b))
* precision issue while submitting the stock entry ([#36575](#36575)) ([a864e07](a864e07))
* re-add permission that was unintentionally removed ([#36663](#36663)) ([99777d3](99777d3))
* **RFQ:** link to supplier portal ([eb2f68e](eb2f68e))
* standard formula to calculate the "difference" ([#36612](#36612)) ([716d5c0](716d5c0))
* Tax withholding post LDC limit consumed ([#36611](#36611)) ([1deebe8](1deebe8))
* **test:** replace hardcoded reference to adv with dynamic one ([2e6bfa3](2e6bfa3))
* **test:** test case breakage in Github Actions ([3542df7](3542df7))
* unhide `uom` and `stock_uom` fields in print view ([b49309c](b49309c))
* validation blocks partial payment for SO and PO ([ce08f03](ce08f03))
* wrap none type rate under flt (backport [#36602](#36602)) ([#36604](#36604)) ([63c061e](63c061e))
* wrong currency on financial-statement based reports ([#36524](#36524)) ([3044f46](3044f46))

### Features

* add voucher totals in tds payable report ([#36568](#36568)) ([90b390c](90b390c))
* daily asset depreciation method ([#36587](#36587)) ([2918127](2918127))
* Reallow customizing company abbreviation on setup. ([#36646](#36646)) ([ca34b63](ca34b63))

### Performance Improvements

* **invoice:** Faster return amount query (backport [#36556](#36556)) ([#36557](#36557)) ([fe41be9](fe41be9))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item Shortage Report display disabled items
1 participant
@s-aga-r