fix: standard formula to calculate the "difference" #36612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
(cherry picked from commit 843e77e)
deepeshgarg007
pushed a commit
that referenced
this pull request
Aug 14, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
# [14.35.0](v14.34.3...v14.35.0) (2023-08-16) ### Bug Fixes * Allow backdated repayment cancels for term loans ([1377cf4](1377cf4)) * allow negative stock condition for batch item ([#36586](#36586)) ([ee04c6d](ee04c6d)) * AR/AP report based on payment terms ([#36574](#36574)) ([ac0fff7](ac0fff7)) * better remarks on Cr note created by Reconciliation ([5443592](5443592)) * Button Alignment center in hero slider ([#36607](#36607)) ([b131f70](b131f70)), closes [#36561](#36561) * cr/dr note should be posted for exc gain/loss ([349601b](349601b)) * disallow mulitple SO with same PO No ([b901cfd](b901cfd)) * don't show disabled items in `Item Shortage Report` (backport [#36550](#36550)) ([#36571](#36571)) ([19cfcea](19cfcea)) * fetch `Stock UOM` from Item if not set (backport [#36606](#36606)) ([#36617](#36617)) ([8b13185](8b13185)) * Group Account total not showing in Financial Statements ([2912648](2912648)) * incorrect available qty for backdated stock reco with batch ([#36581](#36581)) ([2800ad3](2800ad3)) * incorrect gain/loss on allocation change on reconciliation tool ([39c439d](39c439d)) * Make default sales update frequency as monthly instead of each transaction ([4ca1f3b](4ca1f3b)) * move company rename to long queue ([8083c0b](8083c0b)) * precision issue while submitting the stock entry ([#36575](#36575)) ([a864e07](a864e07)) * re-add permission that was unintentionally removed ([#36663](#36663)) ([99777d3](99777d3)) * **RFQ:** link to supplier portal ([eb2f68e](eb2f68e)) * standard formula to calculate the "difference" ([#36612](#36612)) ([716d5c0](716d5c0)) * Tax withholding post LDC limit consumed ([#36611](#36611)) ([1deebe8](1deebe8)) * **test:** replace hardcoded reference to adv with dynamic one ([2e6bfa3](2e6bfa3)) * **test:** test case breakage in Github Actions ([3542df7](3542df7)) * unhide `uom` and `stock_uom` fields in print view ([b49309c](b49309c)) * validation blocks partial payment for SO and PO ([ce08f03](ce08f03)) * wrap none type rate under flt (backport [#36602](#36602)) ([#36604](#36604)) ([63c061e](63c061e)) * wrong currency on financial-statement based reports ([#36524](#36524)) ([3044f46](3044f46)) ### Features * add voucher totals in tds payable report ([#36568](#36568)) ([90b390c](90b390c)) * daily asset depreciation method ([#36587](#36587)) ([2918127](2918127)) * Reallow customizing company abbreviation on setup. ([#36646](#36646)) ([ca34b63](ca34b63)) ### Performance Improvements * **invoice:** Faster return amount query (backport [#36556](#36556)) ([#36557](#36557)) ([fe41be9](fe41be9))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we changed the closing_amount field, the formula was used:
difference = expected_amount - closing_amount
when executing the refresh_payments method, it executed the formula:
difference = closing_amount - expected_amount
User was lost with this logic...
Standardized to:
difference = closing_amount - expected_amount