fix: download materials request plan in production plan #41886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
added a commit
that referenced
this pull request
Jun 13, 2024
…-41886 fix: download materials request plan in production plan (backport #41886)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version: 15 & 14
fixes: #41862
Issue:
When the for_warehouse field in the form is not selected, the warehouses_data array incorrectly includes an object with warehouse: empty string(''). This results in displaying empty string('') in the UI, which is not the desired behavior.
Changes Made:
Updated the JavaScript code to check if frm.doc.for_warehouse is not an empty string before adding the warehouse property to the warehouses_data array.
If frm.doc.for_warehouse is an empty string, the array will not include the warehouse property, thus avoiding the display of empty string('') in the UI.
Before:
Before.webm
After:
After.webm