Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download materials request plan in production plan (backport #41886) #41888

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 13, 2024

Version: 15 & 14

fixes: #41862

Issue:
When the for_warehouse field in the form is not selected, the warehouses_data array incorrectly includes an object with warehouse: empty string(''). This results in displaying empty string('') in the UI, which is not the desired behavior.

Changes Made:
Updated the JavaScript code to check if frm.doc.for_warehouse is not an empty string before adding the warehouse property to the warehouses_data array.
If frm.doc.for_warehouse is an empty string, the array will not include the warehouse property, thus avoiding the display of empty string('') in the UI.

Before:
Before.webm

After:
After.webm


This is an automatic backport of pull request #41886 done by [Mergify](https://mergify.com).

@rohitwaghchaure rohitwaghchaure merged commit ac2e760 into version-15-hotfix Jun 13, 2024
6 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-15-hotfix/pr-41886 branch June 13, 2024 05:54
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.27.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants