fix: reverse debit credit for party gl entry in payment entry based on negative amount #42367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
ljain112
force-pushed
the
fix-payment-entry
branch
from
ce49b06
to
8ec80af
Compare
ljain112
changed the title
ljain112
changed the title
vorasmit
added
backport version-15-hotfix
squash
vorasmit
added a commit
that referenced
this pull request
Jul 31, 2024
…-42367 fix: reverse debit credit for party gl entry in payment entry based on negative amount (backport #42367)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
# [15.32.0](v15.31.5...v15.32.0) (2024-08-07) ### Bug Fixes * 'undefined' in PL and BS report summary on Consolidated report ([3da7071](3da7071)) * all warehouse filter for the stock report (backport [#42584](#42584)) ([#42604](#42604)) ([830b95b](830b95b)) * company filter for filtring tax withheld vouchers ([3ad1f2d](3ad1f2d)) * disable primary action button only when there are no active capitalization ([2d644ac](2d644ac)) * Discount and taxes in return document should follow the reference document (backport [#41911](#41911)) ([#42574](#42574)) ([9321408](9321408)) * do not update item price and last purchase rate for inter transf… (backport [#42616](#42616)) ([#42633](#42633)) ([59b9b7d](59b9b7d)) * german translations ([f27e9f3](f27e9f3)) * inter transfer delivery note issue with batch (backport [#42552](#42552)) ([#42556](#42556)) ([97cc308](97cc308)) * min height for rows in sales funnel ([2f81c99](2f81c99)) * resolved conflict ([#42557](#42557)) ([c3293d1](c3293d1)) * reverse debit credit for party gl entry in payment entry based on negative amount ([#42367](#42367)) ([14f9aef](14f9aef)) * set currency on change of company considering customer default currency (backport [#42405](#42405)) ([#42547](#42547)) ([7c8d13c](7c8d13c)) * set query filters for sales / purchase tax template on PE ([dc9cf74](dc9cf74)) * use get_last_day to get the correct date (backport [#42564](#42564)) ([#42598](#42598)) ([2de86eb](2de86eb)) ### Features * expiry date column in Available Batch Report (backport [#42628](#42628)) ([#42642](#42642)) ([d8768c5](d8768c5))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/18369
When allocated amount is negative and we are paying the receivable party type or receiving from payable party type we need to reverse debit/credit because due to negative amount it will get reversed again.
Before:
If there is negative outstanding for a Puchase Invoice then user was not able to submit the document.
After:
Document is submitted successfully.
Review Tip: Hide whitespaces to view actual changes