Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not update item price and last purchase rate for inter transf… #42616

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

For intercompany transactions, the system uses the valuation rate as the rate, which should not be updated in the Item Price or in the 'Last Purchase Rate' field of the item master.

@github-actions github-actions bot added buying needs-tests This PR needs automated unit-tests. stock labels Aug 5, 2024
@rohitwaghchaure rohitwaghchaure merged commit c8af544 into frappe:develop Aug 5, 2024
18 checks passed
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Aug 5, 2024
mergify bot pushed a commit that referenced this pull request Aug 5, 2024
#42616)

fix: do not update item price and last purchase rate for inter transfer transaction
(cherry picked from commit c8af544)
mergify bot pushed a commit that referenced this pull request Aug 5, 2024
#42616)

fix: do not update item price and last purchase rate for inter transfer transaction
(cherry picked from commit c8af544)
rohitwaghchaure added a commit that referenced this pull request Aug 6, 2024
…… (backport #42616) (#42632)

fix: do not update item price and last purchase rate for inter transf… (#42616)

fix: do not update item price and last purchase rate for inter transfer transaction
(cherry picked from commit c8af544)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure added a commit that referenced this pull request Aug 6, 2024
…… (backport #42616) (#42633)

fix: do not update item price and last purchase rate for inter transf… (#42616)

fix: do not update item price and last purchase rate for inter transfer transaction
(cherry picked from commit c8af544)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 7, 2024
# [14.71.0](v14.70.14...v14.71.0) (2024-08-07)

### Bug Fixes

* 'undefined' in PL and BS report summary on Consolidated report ([a5e1432](a5e1432))
* company filter for filtring tax withheld vouchers ([b7731c8](b7731c8))
* do not update item price and last purchase rate for inter transf… (backport [#42616](#42616)) ([#42632](#42632)) ([5c5349e](5c5349e))
* filter condition in item-wise purchase register ([bc9b461](bc9b461))
* fixed depreciation calculation as per income tax act ([8df1079](8df1079))
* item_code filter in item-wise sales register ([f0f8a2f](f0f8a2f))
* min height for rows in sales funnel ([7086a96](7086a96))
* set query filters for sales / purchase tax template on PE ([c8d8536](c8d8536))
* slowness in reposting dependent vouchers. (backport [#42282](#42282)) ([#42569](#42569)) ([3fb6f97](3fb6f97))

### Features

* expiry date column in Available Batch Report (backport [#42628](#42628)) ([#42641](#42641)) ([83928bb](83928bb))
frappe-pr-bot pushed a commit that referenced this pull request Aug 7, 2024
# [15.32.0](v15.31.5...v15.32.0) (2024-08-07)

### Bug Fixes

* 'undefined' in PL and BS report summary on Consolidated report ([3da7071](3da7071))
* all warehouse filter for the stock report (backport [#42584](#42584)) ([#42604](#42604)) ([830b95b](830b95b))
* company filter for filtring tax withheld vouchers ([3ad1f2d](3ad1f2d))
* disable primary action button only when there are no active capitalization ([2d644ac](2d644ac))
* Discount and taxes in return document should follow the reference document (backport [#41911](#41911)) ([#42574](#42574)) ([9321408](9321408))
* do not update item price and last purchase rate for inter transf… (backport [#42616](#42616)) ([#42633](#42633)) ([59b9b7d](59b9b7d))
* german translations ([f27e9f3](f27e9f3))
* inter transfer delivery note issue with batch (backport [#42552](#42552)) ([#42556](#42556)) ([97cc308](97cc308))
* min height for rows in sales funnel ([2f81c99](2f81c99))
* resolved conflict ([#42557](#42557)) ([c3293d1](c3293d1))
* reverse debit credit for party gl entry in payment entry based on negative amount ([#42367](#42367)) ([14f9aef](14f9aef))
* set currency on change of company considering customer default currency (backport [#42405](#42405)) ([#42547](#42547)) ([7c8d13c](7c8d13c))
* set query filters for sales / purchase tax template on PE ([dc9cf74](dc9cf74))
* use get_last_day to get the correct date (backport [#42564](#42564)) ([#42598](#42598)) ([2de86eb](2de86eb))

### Features

* expiry date column in Available Batch Report (backport [#42628](#42628)) ([#42642](#42642)) ([d8768c5](d8768c5))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant