-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Discount and taxes in return document should follow the reference document (backport #41911) #42573
fix: Discount and taxes in return document should follow the reference document (backport #41911) #42573
Conversation
…e document (#41911) * fix: Discount and taxes in return document should follow the reference document * fix: Ignore Pricing rule on debit/credit note if created against PI/SI with test cases * fix: linter issue (cherry picked from commit 2811984) # Conflicts: # erpnext/controllers/sales_and_purchase_return.py
Cherry-pick of 2811984 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
## [14.73.1](v14.73.0...v14.73.1) (2024-09-04) ### Bug Fixes * adjust price insertion logic for internal suppliers/customers ([#42988](#42988)) ([3912c68](3912c68)) * default fiscal year in report v14 ([#42960](#42960)) ([9db7f7b](9db7f7b)) * Discount and taxes in return document should follow the reference document (backport [#41911](#41911)) ([#42573](#42573)) ([c55f8e3](c55f8e3)) * indentation ([e8cfb4d](e8cfb4d)) * removed extra filter condition ([db319f9](db319f9)) * resolve gl entries duplication in asset purchase workflow ([#41845](#41845)) ([b3c9697](b3c9697)) * retain date filter when redirecting in Profit and Loss report ([c87f2d2](c87f2d2)) * set up filters for dimensions ([450b3f3](450b3f3)) * typeerror on Payment Entry ([dda4002](dda4002)) * typerror on default_currency ([22b283d](22b283d))
🎉 This PR is included in version 14.73.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
If a credit note is created against a sales invoice, the credit note should follow the same discount (based on the pricing rule) and tax template as in the original sales invoice.
Previously, if we changed the discount on the pricing rule after creating the original sales invoice, the system overwrites the discount on the credit note based on the updated pricing rule.
Similarly, the item tax template and tax table is overwritten based on the updated item tax template in the Item master.
This is an automatic backport of pull request #41911 done by Mergify.