Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust price insertion logic for internal suppliers/customers #42988

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ljain112
Copy link
Contributor

Item Prices are not fetched for internal customer/supplier
Related To: #42616

Backport v14 and v15

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/20980

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Aug 29, 2024
@vorasmit vorasmit merged commit 38f925b into frappe:develop Sep 4, 2024
12 of 13 checks passed
mergify bot pushed a commit that referenced this pull request Sep 4, 2024
…42988)

* fix: adjust price insertion logic for internal suppliers/customers

* refactor: correct indentation, specify conditions within function

* fix: typo

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
(cherry picked from commit 38f925b)
mergify bot pushed a commit that referenced this pull request Sep 4, 2024
…42988)

* fix: adjust price insertion logic for internal suppliers/customers

* refactor: correct indentation, specify conditions within function

* fix: typo

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
(cherry picked from commit 38f925b)
vorasmit added a commit that referenced this pull request Sep 4, 2024
…-42988

fix: adjust price insertion logic for internal suppliers/customers (backport #42988)
vorasmit added a commit that referenced this pull request Sep 4, 2024
…-42988

fix: adjust price insertion logic for internal suppliers/customers (backport #42988)
frappe-pr-bot pushed a commit that referenced this pull request Sep 4, 2024
## [14.73.1](v14.73.0...v14.73.1) (2024-09-04)

### Bug Fixes

* adjust price insertion logic for internal suppliers/customers ([#42988](#42988)) ([3912c68](3912c68))
* default fiscal year in report v14 ([#42960](#42960)) ([9db7f7b](9db7f7b))
* Discount and taxes in return document should follow the reference document (backport [#41911](#41911)) ([#42573](#42573)) ([c55f8e3](c55f8e3))
* indentation ([e8cfb4d](e8cfb4d))
* removed extra filter condition ([db319f9](db319f9))
* resolve gl entries duplication in asset purchase workflow ([#41845](#41845)) ([b3c9697](b3c9697))
* retain date filter when redirecting in Profit and Loss report ([c87f2d2](c87f2d2))
* set up filters for dimensions ([450b3f3](450b3f3))
* typeerror on Payment Entry ([dda4002](dda4002))
* typerror on default_currency ([22b283d](22b283d))
frappe-pr-bot pushed a commit that referenced this pull request Sep 5, 2024
## [15.34.1](v15.34.0...v15.34.1) (2024-09-05)

### Bug Fixes

* add the company in payment request bcz delete company transactions (backport [#42664](#42664)) ([#42982](#42982)) ([42e7725](42e7725))
* added app permission check for apps page ([a35ce12](a35ce12))
* adjust price insertion logic for internal suppliers/customers ([#42988](#42988)) ([daa75ee](daa75ee))
* auto reorder material request mail issue (backport [#43066](#43066)) ([#43068](#43068)) ([d2b2002](d2b2002))
* **capitalization:** debit cwip account instead of fixed asset account ([#42857](#42857)) ([f3c60ea](f3c60ea))
* company accounts setup_queries ([b99cdb5](b99cdb5))
* disabled batches showing in the list (backport [#43024](#43024)) ([#43069](#43069)) ([56dad7d](56dad7d))
* don't allow capitalizing only service item for new composite asset ([a833010](a833010))
* improve asset item matching logic ([3bb1867](3bb1867))
* indentation ([4d7c0c0](4d7c0c0))
* link Purchase Invoice and Receipt Items to Asset ([1121c66](1121c66))
* retain date filter when redirecting in Profit and Loss report ([f0e3fb4](f0e3fb4))
* typeerror on Payment Entry ([6d51d14](6d51d14))
* typerror on default_currency ([7d6984c](7d6984c))
* update develop_version in hooks ([6c8e0fd](6c8e0fd))
* validate component quantity according to BOM (backport [#43011](#43011)) ([#43014](#43014)) ([fee2255](fee2255))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants