feat: Ledger for advance payment

[ruthra-kumar]

Issue

System allows advance payment to exceed Sales / Purchase Order grand total.

Consider below scenario,

1. Sales Order of 10000 /-
2. Make an Advance Payment of 2000 /-
3. Make a Partial Invoice (2000 /-) for Sales Order and Reconcile the advance against the invoice
4. Now, try making an Advance payment of 10000 /-. System allows this. It should've only allowed up to 8000 /-

Current Limitation

This happens because technically there is no distinction between a Normal Payment and an Advance Payment. So there is no persistent data structure to track the Advance Amount received for a Sales / Purchase Order. This distinction is inferred solely based on the allocation. If the Payment is allocated to a Sales / Purchase Order, then it is considered as an Advance Payment.

The problem with this approach is once reconciliation happens, the allocation to Sales / Purchase Order are replaced with an Invoice. So, we loose the critical information: A certain amount was received as an Advance, but it is now allocated to an Invoice.

Solution

A separate ledger to track Advance Payments against Sales Order or Purchase Order that only captures Submit and Cancel events. This way Reconciliation / Un-Reconciliation doesn't affect the advance amount calculation.

Event	Ledger Effect
Submit	Update
Reconcile	-
Unreconcile	-
Cancel	Update

todo:

• Refactor code; move logic to controller class
• Patch to migrate existing records
• Test for Foreign currency Transaction
• [ ] Refactor HR code as well

For Employee Advance and Gratuity, reference is maintained even after the advance has been allocated. So, HRMS will continue to use GL Entry for calculating advance_paid,

no-docs