Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update readme #433

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: update readme #433

wants to merge 8 commits into from

Conversation

sidemt
Copy link
Member

@sidemt sidemt commented Aug 20, 2024

Checklist:

@sidemt sidemt requested a review from a team as a code owner August 20, 2024 18:22
DanielRosa74
DanielRosa74 reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the instructions look solid to me. I'll try to follow them here. Thanks, @sidemt!

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
sidemt and others added 2 commits August 21, 2024 03:58
@sidemt @DanielRosa74
fix: typo
5dc039c 
Co-authored-by: DanielRosa74 <58576743+DanielRosa74@users.noreply.github.com>
@sidemt @DanielRosa74
fix: add link to explain postediting
cc4e368 
Co-authored-by: DanielRosa74 <58576743+DanielRosa74@users.noreply.github.com>
DanielRosa74
DanielRosa74 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RafaelDavisH
RafaelDavisH reviewed Aug 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@sidemt @RafaelDavisH
Update README.md
89864d5 
Co-authored-by: Rafael D. Hernandez <rafaeldavish443@gmail.com>
RafaelDavisH
RafaelDavisH requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@RafaelDavisH RafaelDavisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a final 5th step to make it clear that the contributor is only responsible for the first four steps. After that, the language leads will take care of everything else.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sidemt and others added 2 commits August 22, 2024 22:31
@sidemt @RafaelDavisH
Update README.md
8369e92 
Co-authored-by: Rafael D. Hernandez <rafaeldavish443@gmail.com>
@sidemt @RafaelDavisH
Update README.md
15cafe5 
Co-authored-by: Rafael D. Hernandez <rafaeldavish443@gmail.com>
@sidemt
Copy link
Member Author

sidemt commented Aug 22, 2024

@RafaelDavisH Before merging this PR, do we want to inform other language leads about this new workflow and ask feedback from them?

@RafaelDavisH
Copy link
Collaborator

Yes, we ask them to run the GH actions a couple of times and provide some feedback before we officially announce it to the community of proofreaders.

What you think @DanielRosa74 ?

@DanielRosa74
Copy link
Contributor

Yes, we ask them to run the GH actions a couple of times and provide some feedback before we officially announce it to the community of proofreaders.

What you think @DanielRosa74 ?

Sounds good, @RafaelDavisH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokomatsud yokomatsud yokomatsud left review comments

@RafaelDavisH RafaelDavisH RafaelDavisH requested changes

@DanielRosa74 DanielRosa74 DanielRosa74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sidemt @RafaelDavisH @DanielRosa74 @yokomatsud