Skip to content
This repository has been archived by the owner on Apr 1, 2021. It is now read-only.

Article: Data-Structure-ARRAYS.md #1052

Merged
merged 14 commits into from
May 29, 2016
Merged

Article: Data-Structure-ARRAYS.md #1052

merged 14 commits into from
May 29, 2016

Conversation

varunu28
Copy link
Contributor

No description provided.

@varunu28
Copy link
Contributor Author

@alayek @ds-249
Please have a look and suggest the changes which needs to be done.

@varunu28
Copy link
Contributor Author

Sure
On 28 May 2016 08:41, "Deepak Sattiraju" notifications@github.com wrote:

@varunu28 https://github.com/varunu28, you might as well mention that,
lists are mutable in python, but arrays aren't.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1052 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHUgcE2rKsVkfvxQu23QaOkjfo8eAeesks5qF7JxgaJpZM4Io9yG
.

@varunu28
Copy link
Contributor Author

@ds-249 Even arrays are mutable in Python. We can change the values in an array by referencing the particular index.

@ds-249
Copy link
Contributor

ds-249 commented May 28, 2016

@varunu28 I meant arrays in other languages, like C, Java. You declare them with the dimensions in the beginning, and you can't change it on the go like in python

@varunu28
Copy link
Contributor Author

@ds-249 Yes. So the arrays have the same property as that of a list in Python. Both are mutable and we can change it on the go. Should I mention that there is no fixed size which needs to be allocated at time of declaration in Python whereas that needs to be done in languages like Java?

@ds-249
Copy link
Contributor

ds-249 commented May 28, 2016

@varunu28 Yes. You can mention that if you write snippets in Java, you may want to try this link

@varunu28
Copy link
Contributor Author

@ds-249 Well I was not planning to write code snippets in Java, Let me discuss this with @alayek .

@koustuvsinha
Copy link
Member

Please change the file name like this :

- Data-Structure-ARRAYS.md
+ Python-Arrays.md

If its a python specific article (from the looks of it). However, if its a generic Data Structures Article, then you should provide implementations in few other languages as well.

@varunu28
Copy link
Contributor Author

@koustuvsinha I am creating this article for #1044 so should I provide implementations in other languages also and if yes then in which other language?

@ghost ghost self-assigned this May 28, 2016
a collection of data, but it is often more useful to think of an `array` as a collection of variables of the same type.

`array` consists of contiguous memory locations. The lowest address corresponds to the first element and the highest address to the last
element.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a new line here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atjonathan Wanted to explain a different point about the memory allocation of arrays so a new paragraph

@koustuvsinha
Copy link
Member

okay, as per the issue its either Java or Python 3. Then you have done ok here, but I need to discuss this more with Wiki team. Do implement the reviews given by others :)

@varunu28
Copy link
Contributor Author

@atjonathan I have done the changes. Please check

Python doesn't have a native `array` data structure. An `array` in Python should not be confused with `list`. The major difference between a `list`
and an `array` in Python is that a `list` can have different types of values whereas an `array` should have all the values of same type.

####Declaration of `array`:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

####Declaration of array: Add spaces between #### and Declaration of array:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atjonathan Done

@alayek
Copy link
Member

alayek commented May 28, 2016

I left a few comments, hopefully you would fix that.

Other than that,

LGTM 👍

Let's :shipit: 📦

@ghost
Copy link

ghost commented May 28, 2016

LGTM 👍

@koustuvsinha, ready when you are 😜

@@ -0,0 +1,61 @@
#Arrays
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-#Arrays
+# Data Structure Arrays

Don't use : on the first title, they break the generator and get removed anyways.

@Rafase282
Copy link
Member

Why not Data-Structure-Arrays.md for the filename?

@Rafase282
Copy link
Member

Whoever merges this, remember to use the squash instead of just merge.

@varunu28
Copy link
Contributor Author

@Rafase282 I have implemented the changes. Please have a look.

@Rafase282
Copy link
Member

Looks good but the indentation is not needed on the code blocks.

@varunu28
Copy link
Contributor Author

@Rafase282 I have removed the indentation

@koustuvsinha
Copy link
Member

LGTM

Lets 📦 :shipit:

@alayek
Copy link
Member

alayek commented May 29, 2016

@atjonathan I am merging this...

@alayek alayek merged commit c521e04 into freeCodeCamp:master May 29, 2016
@BerkeleyTrue BerkeleyTrue removed the QA label May 29, 2016
@ghost
Copy link

ghost commented May 29, 2016

@alayek Np :) I was 😴

tanham added a commit to tanham/wiki that referenced this pull request May 30, 2016
* Markdown fixes for hash tables

* Add cities, May 28 2016

* Article: Data-Structure-ARRAYS.md (freeCodeCamp#1052)

* Create Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Rename Data-Structure-ARRAYS.md to Data-Structure-Arrays.md

* Update Data-Structure-Arrays.md
tanham pushed a commit to tanham/wiki that referenced this pull request Jun 2, 2016
* Create Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Rename Data-Structure-ARRAYS.md to Data-Structure-Arrays.md

* Update Data-Structure-Arrays.md
tanham pushed a commit to tanham/wiki that referenced this pull request Jun 2, 2016
* Create Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Rename Data-Structure-ARRAYS.md to Data-Structure-Arrays.md

* Update Data-Structure-Arrays.md

revised JS-Code-Linting
tanham pushed a commit to tanham/wiki that referenced this pull request Jun 2, 2016
* Create Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Rename Data-Structure-ARRAYS.md to Data-Structure-Arrays.md

* Update Data-Structure-Arrays.md

revised JS-Code-Linting
tanham pushed a commit to tanham/wiki that referenced this pull request Jun 2, 2016
* Create Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Update Data-Structure-ARRAYS.md

* Rename Data-Structure-ARRAYS.md to Data-Structure-Arrays.md

* Update Data-Structure-Arrays.md

revised JS-Code-Linting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants