Adds rpm buider container.. swaps out build scripts #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using fedora 25 to match to what Qubes 4 is using on dom0
Also swaps requirements.txt for pipenv files. Big thing to note that as we lost functionality on the build-all default target. Honestly, I cant see any reason we would ever want to build all in one session so I'm not too worried about it. The biggest motivator for doing this is .. I cant stand ansible's docker module. It doesnt handle caching well and most of all ansible output story sucks.. and I really wanted to see more of a live rolling output from docker. I just realized after this I could have used docker-compose in a similar fashion and ditch these meta.yml files. 🤷 Im kind of lazy to go back and convert now but if someone gets loud enough i might be convinced
conorsch
approved these changes
Nov 6, 2018
msheiny
added a commit
that referenced
this pull request
Aug 16, 2019
Adds rpm buider container.. swaps out build scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
There is also significant tooling change surrounding the build scripts. I put some reasoning in the commit message
To expand on that - it was so annoying to do any debugging during docker building iteration that this drove me to swap things out.
Already pushed to quay.io
To test locally?
Either
pipenv run ./build.py rpmbuilderor jump into the virtualenv yourself and just run./build.py rpmbuilder