Downlod replies

[joshuathayer]

Building off #99, also spawn a thread for downloading and processing Replies from the journalist.

Aside from some minor refactoring to pull out common code between the Message the Reply fetching threads, there's not much novel here. It follows the Message-fetching model pretty closely.

Closes #108

[joshuathayer]

s/submissions/replies

[joshuathayer]

same, s/submission/reply

[redshiftzero]

@joshuathayer and I reviewed this in person, looks good! Will test in Qubes and plan to merge this in for inclusion in the first securedrop-client deb

(To the interested observer, the advantage of having these separate reply and message threads is parallel download/decrypt happening for replies and messages, cc: #106)

[redshiftzero]

hey so I was on this branch and I hit this error:

Running app with home directory: /var/folders/gv/2r10zvfj303fyd5_6yn_p0b80000gn/T/tmp.EEN4XTsi
Traceback (most recent call last):
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/gui/main.py", line 158, in on_source_changed
    self.show_conversation_for(self.current_source)
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/gui/main.py", line 189, in show_conversation_for
    "<Reply not yet downloaded>")
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/gui/main.py", line 167, in add_item_content_or
    adder(item.content)
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/models.py", line 24, in content
    return self.data.get(fn_no_ext)
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/data.py", line 16, in get
    msg = fh.read()
  File "/Users/redshiftzero/.virtualenvs/securedrop-client-l0Id-Ywn/lib/python3.5/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xca in position 0: unexpected end of data

The decrypted replies are getting written to the data directory but they are only one byte long.. I have to run but I will work on debugging this first thing tomorrow (if someone else notices the issue, please comment!)

[joshuathayer]

@redshiftzero, I can take a look at this problem this morning.

[redshiftzero]

figured it out, it was indeed non-Qubes only due to the development test data: freedomofpress/securedrop#3927 resolves

[redshiftzero]

✅ tested in Qubes and non-Qubes (macOS) successfully