Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Test replies: encrypt a string instead of 1 random byte #3927

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

Changes proposed in this pull request:

Testing

make -C securedrop dev

Deployment

Dev environment only

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #3927 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3927   +/-   ##
========================================
  Coverage    84.55%   84.55%           
========================================
  Files           43       43           
  Lines         2726     2726           
  Branches       296      296           
========================================
  Hits          2305     2305           
  Misses         354      354           
  Partials        67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1b845...5c7f35f. Read the comment docs.

@heartsucker heartsucker merged commit 0171ff6 into develop Nov 7, 2018
@heartsucker heartsucker deleted the fix-dev-reply-data branch November 7, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants