Eng 7389 prebid 4.42.1 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* for optional fields, only send to servers if populated * adding some logging to id5 submodule to make debugging easier * update user id integration example for id5 to user html5 not cookie * remove .only from tests * remove checks for loginfo since now we are using it more broadly
* Shinze adapter version 1.0.0 * map for arrays replaced with forEach, fpd temporarily removed * switched to only public interface testing * Usage of URL removed
… other improvements (prebid#6583) * refactor user id example to properly receive TCFv2 consent string by using static consent object - added a list of user id modules' gvl ids to enable consent for them within prebid core - also reformatted the entire document to make it easier to read - added output of the eids array so it's easy to see what's happening * smaller tab size
* Added automatic tzo and targetId to adserver request. * Fixing issues with bid price being too low. * Fixing issues with bid price being too low. * Ad server response places bids in correct placement * Adnuntius Bid Adapter ordered responses * Ad server response places bids in correct placement * Adnuntius Bid Adapter ordered responses * RTD Provider rebase * wrongly merged to master
…id#6629) * add support for case insensitive userId names * update unit test
…r bunner request is too long (prebid#6549) Co-authored-by: Anton Tsymuk <antontsymuk@Antons-MacBook-Pro.local>
1) Update core to convert adUnits passed into requestBids (previously only global) 2) Update to RP Analytics adapter to look in ortb2Imp instead of legacy fpd
…rebid#6577) * Update adxcgBidAdapter.js * Update adxcgcom .js client side adapter * lgtm review update * check for parameter existenct onBidWon * Update adxcgBidAdapter.js * Update adxcgBidAdapter.js * Update adxcgBidAdapter.md * Update adxcgBidAdapter.md
* Submit Zeta Adapter to Prebid * comments addressed * demo changes * additional polishing * additional polishing * Update hello_world.html * remove extraneous changes to hello_world.html * no, really this time * additional polishing * add unit test * update to include additional OpenRTB fields and objects * Update to include addtional OpenRTB fields and objects
* added check for bidder name validity * adding aliases in-scope for the validity check
* Implemented Kobler bidder adapter. * Added missing '' to dealId example in parameters table. * Added information on supporting the Floors module. * Implemented tests for isBidRequestValid. * Implemented tests for inherited functions. * Removed unnecessary conditions and quotation marks. * Added TODO about deciding what to do in debug mode. * Added TODO about checking which currencies are allowed. * Added information on parameters read from the first bid only. * Fixed missing indexing operator when checking if mainSize is 0x0. * Implemented tests for buildRequests. * Implemented tests for interpretResponse. * Implemented tests for onBidWon. * Implemented tests for onTimeout. * Added some missing semicolons. * Removed TODO about allowed currencies. * Removed setting test in debug mode and related TODOs. * Removed optional pos parameter. * Removed optional bidfloor parameter and use floorPrice instead of floorprice. * Added support for multiple deal ID parameters. * Fixed formatting. * Added more explanation about the value of position param. * Moved pos property into Kobler-specific banner extension. * Simplifications based on PR comments. * Use getRefererInfo to get page URL for timeout notifications. * Removed TODO about auction type. * Added information on how to generate a sample bid. * Removed reading currency from currency.adServerCurrency.
…rams.publisherId (prebid#6575) * add sspbc adapter * tests for sspbc adapter * sspBC adapter v4.5: set correct creativeId, add adomain to bid.meta, set test mode in adexchange, read site SN from bid response * sspBC adapter v4.5: set meta.advertiserDomains, update test to expect bid.meta * sspBC Adapter: add ajax tests (test ad with & without gdpr) * sspBC Adapter: remove ajax tests * Update adapter to v4.6 Update adapter to v4.6 - add notification endpoint - send bidWon and onTimeout notifications - send CMP version to user sync endpoint * Remove console logs for notification events * Change payload data in onTimeout event * Update tests for sspBC adapter Update tests for sspBC adapter: - add onBidWon test - add onTimeout test - alter getUserSyncs test * Update sspBC adapter to v4.7; enable oneCodeId mode; change module name to ensure combatibility with prebid.org downloader * sspBc adapter: Bug fixes in v4.7 - change notification format, fix oneCode detection data, convert slot number to int * sspbc adapter: fix creating bid.crid, when not present in server response * sspbc adapter: add publisher id to payload * sspbc adapter: fix onecode issues (when bid.params is present, but incomplete) * sspbc adapter: code cleanup * sspbc adapter: ver up (4.8) * sspbc-adapter: update doc * [sspbc-adapter] update test settings Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
…bjs global (prebid#6601) * - Remove module list comment on build - Add pbjs.installedModules with macro to prebid.js - Update gruntfile to replace macro with module array (if empty array all modules included)) * Removed unused code * Removed comma * Recommitting changes * Updated regex to look for either '|" in macro name. Seems there is a difference between dev/prod
…already present on the video request since it's an optional property (prebid#6637)
* Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js * Delete iasBidAdapter.js * Add files via upload * Update README.md * Update README.md
…ts (prebid#6622) * Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js * Delete iasBidAdapter.js * Add files via upload * Update index.js
* Bug fix when parsing FPD data. Check for taxonomyname existence prior to match * Lint check
* AdRiver Bid Adapter: initial prebid.js integration * Added AdRiver Bid Adapter * AdRiver Bid Adapter: update getting floor, via getFloor() * Added internal method _getFloor() * Update test for getFloor() * Remove old currency logic * AdRiver Bid Adapter: update adriverBidAdapter.md * Delete old test parameters * AdRiver Bid Adapter: add meta.advertiserDomains * Added parameter meta.advertiserDomains to interpretResponse * Update test for meta.advertiserDomains
* Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix * Out-Stream render update to SmartPlay 5.2 * ESlint fix * ESlint fix * ESlint fix * adjust tests, fixes * ESlint * adjusted desired bitrate examples * added bid.meta.advertiserDomains support * bug fix for numeric elementID outstream render * fix renderer url * support for floors module Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv>
…ce (prebid#6874) * Fix Prebid 5.0 compliance: leverage floors module * Upgrade adapter version
* Onomagic Bid Adapter: use getFloor function * Onomagic Bid Adapter: fix issues
* Adapter does not seem capable of supporting advertiserDomains prebid#6650 added response comment and some trivial code. * removed a blank line at the end of file added a space behind the // in comments * in response to comment from reviewer. add the aspect of advertiserdomain in unit tests
* add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * add response meda OBJ update version and test code Co-authored-by: ishigami_shingo <s.ishigami@relaido.co.jp> Co-authored-by: cmertv-sishigami <s.ishigami@cmertv.com> Co-authored-by: t_bun <t.bun@cmertv.com>
* AdYouLike Bidder: Handle advertiser domains * fix linting * update tests * fix linting * fix error
…6920) * Add advertiserDomains stub * Use utils from require * Update version * Replace let to const and fix version
* Add lockerdome adapter advertiserDomains support stub for Prebid 5.0 * Add lockerdome adapter advertiserDomains support stub for Prebid 5.0 * fix linting error Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
…rebid#6917) * Update Adtelligent, Adtarget, ViewDeos adapters to support adomain * fix * fix tests
* Smaato bid adapter: Refactor, clean and add tests * Smaato bid adapter: Create individual request to Smaatos server per valid bid request
* re-open pull request reference prebid#6410 * delete Overview * for test , comment out. * for test, comment out. * for test. comment out setConfig. * execute resetConfig aftet test. * execute resetConfig after test. * set emppty bidderConfig after test * fix setBidderConfig and test code * fix test code. * fix * for test resetBidderConfig in config * resetBidderConfig afterEach * setBidderConfig is not executed when ci test
…rride from bidder params, support passing adomain (prebid#6888) * read video params from mediaTypes, and allow override from from bidder * implement meta.advertiserDomain * fix unit tests * allow outstream video
…imes should be present and must be a non-empty array (prebid#6926) * bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array
* add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename * Blue Billywig - Also pass through site config with OpenRTB request * add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Code quality update, always hit user syncs, improved video params * Add support for meta.advertiserDomains to BB Adapter, addresses issue prebid#6466 * kick off circleci tests Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
…#6796) * Master merge issues * Adnuntius Bid Adapter: Added tests for gdpr and segments * Moved segments to read from ortb2 instead of a custom value. * Changed bidder to read segments from ortb2. * fixing lgtm alert
aecook
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to prebid 4.42.1