Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add allowLongAppNames to support longer application names #1489

Merged
merged 3 commits into from
Apr 23, 2024
Merged

feat: Add allowLongAppNames to support longer application names #1489

merged 3 commits into from
Apr 23, 2024

Commits on Mar 28, 2024

  1. feat: Add allowLongAppNames to support longer application names 

    This introduces the helm parameter `cd.allowLongAppNames`. When true, kuberpult accepts app names longer than 39, but maximum 70 characters.
This requires some configuration in Argo CD to work.
See #1183 for how to enable it in Argo CD.

Closes issue #1182

This was implemented by @jdvgh
In order to get this through our CI, I had to create this new PR.
Old PR: #1183
    @jdvgh @sven-urbanski-freiheit-com
    jdvgh authored and sven-urbanski-freiheit-com committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3459df6 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Merge branch 'main' into feature/support-longer-application-names

    @sven-urbanski-freiheit-com
    sven-urbanski-freiheit-com authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ed51f43 View commit details
    Browse the repository at this point in the history

  2. fix merge conflict

    @sven-urbanski-freiheit-com
    sven-urbanski-freiheit-com committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    21ebb2a View commit details
    Browse the repository at this point in the history