feat: Add allowLongAppNames to support longer application names #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
feature/support-longer-application-names
branch
5 times, most recently
from
3f6409c
to
805d0df
Compare
|
@sven-urbanski-freiheit-com if I should re-commit with another message just give me a heads-up. I see the commit lint is failing. |
that was a bug in the commit linter, should be fixed in a minute: #1492 |
This introduces the helm parameter `cd.allowLongAppNames`. When true, kuberpult accepts app names longer than 39, but maximum 70 characters. This requires some configuration in Argo CD to work. See #1183 for how to enable it in Argo CD. Closes issue #1182 This was implemented by @jdvgh In order to get this through our CI, I had to create this new PR. Old PR: #1183
sven-urbanski-freiheit-com
force-pushed
the
feature/support-longer-application-names
branch
from
805d0df
to
3459df6
Compare
sven-urbanski-freiheit-com
deleted the
feature/support-longer-application-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the helm parameter
cd.allowLongAppNames. When true, kuberpultaccepts app names longer than 39, but maximum 70 characters.
This requires some configuration in Argo CD to work.
See #1183 (comment)
for how to enable it in Argo CD.
This was implemented by @jdvgh
In order to get this through our CI, I had to create this new PR.
Old PR: #1183
Closes: #1182