Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change missingValue to missingValues plural #353

Closed
rufuspollock opened this issue Dec 22, 2016 · 5 comments
Closed

Change missingValue to missingValues plural #353

rufuspollock opened this issue Dec 22, 2016 · 5 comments
Assignees
@pwalsh
Milestone
v1.0

Comments

@rufuspollock
Copy link
Contributor

No description provided.

@rufuspollock rufuspollock added this to the Version-1 milestone Dec 22, 2016
@pwalsh pwalsh self-assigned this Dec 22, 2016
@pwalsh
Copy link
Member

pwalsh commented Dec 22, 2016

I'll add it.

@ethanwhite
Copy link
Collaborator

I'm doing a round of cleanup on our Data Retriever package files and just wanted to confirm that this is where the 1.0 spec is going. Is something like this what we should be using?

"missingValues": ["NA", -999]

@ethanwhite ethanwhite mentioned this issue Jan 11, 2017
Closed
ethanwhite added a commit to ethanwhite/retriever that referenced this issue Jan 13, 2017
@ethanwhite
Using missingValues instead of nulls in json files
e78d039 
This is being added to the datapackage spec. See:
frictionlessdata/datapackage#353
ethanwhite added a commit to ethanwhite/retriever that referenced this issue Jan 13, 2017
@ethanwhite
Using missingValues instead of nulls in json files
b5cd06b 
This is being added to the datapackage spec. See:
frictionlessdata/datapackage#353
ethanwhite added a commit to ethanwhite/retriever that referenced this issue Jan 14, 2017
@ethanwhite
Using missingValues instead of nulls in json files
d264507 
This is being added to the datapackage spec. See:
frictionlessdata/datapackage#353
@rufuspollock
Copy link
Contributor Author

rufuspollock commented Jan 16, 2017 •
edited
Loading

@ethanwhite that is correct 😄

@pwalsh
Copy link
Member

pwalsh commented Jan 30, 2017

in #337 and this issue will close when it is merged.

@pwalsh pwalsh mentioned this issue Jan 30, 2017
Merged
33 tasks
@pwalsh
Copy link
Member

pwalsh commented Feb 5, 2017

We won't merge #337 until we can support all the changes in the core implementations we maintain. So closing this as it is implemented in #337 , as leaving it open creates confusion.

@pwalsh pwalsh closed this as completed Feb 5, 2017
iskunalpal pushed a commit to iskunalpal/retriever that referenced this issue Mar 1, 2017
@ethanwhite
Using missingValues instead of nulls in json files
18da70a 
This is being added to the datapackage spec. See:
frictionlessdata/datapackage#353
rufuspollock added a commit that referenced this issue May 22, 2017
@rufuspollock
[jts,#353,#359,!][s]: missingValues work - fixes #353, fixes #359 (ag…
778439f 
…ain).

* missingValue -> missingValues (plural)
* require it to be an array
* move it to table schema level from field level - fixes #359
* no change to defaults - still just "" (as per #359 discussion)

Also do a fair bit of tidying up / refactoring on layout of spec e.g.

* get rid of specification heading and just have descriptor
* optional "Other Properties" section
* ...
@rufuspollock rufuspollock mentioned this issue May 24, 2017
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwalsh pwalsh

Labels
None yet
Projects
Open Knowledge
Archived in project
Milestone
v1.0
Development

No branches or pull requests
3 participants
@rufuspollock @ethanwhite @pwalsh