-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRY spec generation, Integrate changes to v1 #337
Conversation
@rufuspollock everything I am working on is converging on this branch. I'm now doing a commit per issue. There is no better way around it now - this branch changes the way the specs are written, and has brought many ambiguities (due to wording, etc.) to the surface. To view this branch you will have to run it locally. Honestly, I'm very happy with the results of this work towards a solid v1 of all specs. I'll also ping you when I remove the WIP status. |
So based on this approach and if I've got it right datapackage.json should be changed e.g. from this: resources:
- name: name1
schema: {...}
data: [...]
- name: name2
schema: {...}
data: [...] to resources:
- name: name1
schema: #schema-ref1
data: [#data-ref2]
- name: name2
schema: #schema-ref2
data: [#data-ref2]
schemas:
schema1: {...}
schema2: {...}
data:
data1: {...}
data2: {...} I suppose it's good for JSONSchema purity and for implementations but it looks like we're making datapackage non manual editable - consider 10 resources long datapackage where to change one resource you need to edit file in 3 different places. It could lead to many errors people unwillingness to working on it by hands. Also a descriptor for a single resource should look like this? name: name
schema: #real-schema
data: [#real-data]
real-schema: {...}
real-data: {...} Or I've got it wrong.. |
@roll sorry I'm a bit confused by the above, and how it is JSON Schema-specific? I think you are focused specifically on the JSON Pointer support, which is new, but does not replace normal URL and file path support. i.e.: |
So schema is still inlinable? upd. |
@roll yes. |
Implements the following
author
andmaintainer
type
to licensename