Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional sources seems to be required #580

Closed
Stephen-Gates opened this issue Jan 26, 2018 · 1 comment · Fixed by #585
Closed

Optional sources seems to be required #580

Stephen-Gates opened this issue Jan 26, 2018 · 1 comment · Fixed by #585
Labels

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Jan 26, 2018

sources is an optional property but it seems to be required https://github.com/frictionlessdata/specs/blob/master/schemas/dictionary/common.yml#L277

My understanding is that sources is optional but if it is present it must have a title and may have a path and /or email.

Shouldn't https://github.com/frictionlessdata/specs/blob/master/schemas/dictionary/common.yml#L290 use path instead of uri?
and
https://github.com/frictionlessdata/specs/blob/master/schemas/dictionary/common.yml#L289 use title instead of name

@rufuspollock
Copy link
Contributor

@Stephen-Gates yes, sources is optional and MUST have title.

I think all your corrections are correct -- this mismatch arose from the rewrite last may where we corrected one item without the other (accidentally). Please submit a PR.

Stephen-Gates added a commit to Stephen-Gates/specs that referenced this issue Jan 29, 2018
fixes frictionlessdata#580

not sure if it should be minItems: 0 or just delete line
rufuspollock added a commit that referenced this issue Mar 21, 2018
make sources optional and fix example - fixes #580.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants