Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Source properties #320

Closed
Stephen-Gates opened this issue Dec 12, 2017 · 2 comments
Closed

Validate Source properties #320

Stephen-Gates opened this issue Dec 12, 2017 · 2 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Major Major effort to implement fn:Set-Properties priority:Medium problem:Bug A bug
Milestone
v0.9.0

Comments

@Stephen-Gates
Copy link
Contributor

Current Behaviour (for problems)

If I add a Source but omit the title value but add path and/or email an error is not raised required title to be entered.

The spec requires a title.

Expected Behaviour

An error is raised required title to be entered for each Source.

Your Environment

  • Data Curator version: 0.7.0
  • Operating System and version: e.g. macOS High Sierra 10.13.2
@Stephen-Gates Stephen-Gates added env:MacOS This issue is related to running Data Curator on macOS fn:Set-Properties problem:Bug A bug labels Dec 12, 2017
@Stephen-Gates Stephen-Gates added this to the v1.x.x milestone Dec 12, 2017
@Stephen-Gates Stephen-Gates added priority:Medium env:Windows This issue is related to running Data Curator on Windows labels Dec 13, 2017
@Stephen-Gates
Copy link
Contributor Author

more broadly:

  • email is not validated
  • url or path is not validated
  • path label should be url or path

image

@Stephen-Gates Stephen-Gates changed the title Source Title is not validated as a mandatory field Source properties validation Dec 14, 2017
@Stephen-Gates Stephen-Gates changed the title Source properties validation Validate Source properties Dec 31, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, 0.9.0 Jan 10, 2018
@ghost ghost added the est:Minor Minor effort to implement label Jan 10, 2018
@ghost ghost added est:Major Major effort to implement and removed est:Minor Minor effort to implement labels Jan 25, 2018
@Stephen-Gates
Copy link
Contributor Author

@mattRedBox FYI frictionlessdata/datapackage#580

ghost pushed a commit that referenced this issue Jan 30, 2018
#320. Take control of validators to enable an OR validation.
efd5c29
@ghost ghost closed this as completed in cc761d2 Jan 30, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Major Major effort to implement fn:Set-Properties priority:Medium problem:Bug A bug
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
1 participant
@Stephen-Gates