Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#578] Allow empty missing values #588

Merged
merged 3 commits into from
Mar 21, 2018
Merged

[#578] Allow empty missing values #588

merged 3 commits into from
Mar 21, 2018

Conversation

akariv
Copy link
Member

@akariv akariv commented Feb 3, 2018

Allow setting no entries for the missingValues property in tableschema.

See #578 for details.

@akariv akariv requested a review from roll February 3, 2018 09:08
@Stephen-Gates Stephen-Gates mentioned this pull request Feb 3, 2018
Open
@Stephen-Gates
Copy link
Contributor

Is the specification planned to be changed with this PR?

roll
roll approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roll
Copy link
Member

roll commented Feb 5, 2018 •
edited
Loading

@Stephen-Gates
I don't think the existent text forbids to have an empty missingValues: [] array. So it doesn't seem it should be changed also.

@Stephen-Gates
Copy link
Contributor

@roll agreed it's not forbidden but perhaps missingValues: [] should be explained in contrast to "missingValues": [""]

@akariv
Copy link
Member Author

akariv commented Feb 8, 2018

@Stephen-Gates I updated the spec based on your suggestion.

@akariv akariv requested a review from roll February 8, 2018 07:20
@Stephen-Gates
Copy link
Contributor

Thanks @akariv

@Stephen-Gates Stephen-Gates mentioned this pull request Mar 12, 2018
Closed
@rufuspollock rufuspollock merged commit 0e900fc into master Mar 21, 2018
@Stephen-Gates Stephen-Gates mentioned this pull request Apr 7, 2018
Closed
@rufuspollock rufuspollock deleted the fix/empty-missing-values branch January 29, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll Awaiting requested review from roll

Assignees
No one assigned
Labels
None yet
Projects
Open Knowledge
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akariv @Stephen-Gates @roll @rufuspollock