Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing values at field level #386

Open
Stephen-Gates opened this issue Jan 10, 2018 · 9 comments
Open

Support missing values at field level #386

Stephen-Gates opened this issue Jan 10, 2018 · 9 comments
Labels
f:Feature-request This issue is a request for a new feature fn:Set-Properties fn:Validation status:Blocked 😢 We can't progress this until something else happens
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Jan 10, 2018

Desired Behaviour

Support missingValues at field level - possible changes in specification. See frictionlessdata/datapackage#551

  • Add property to column
  • Use property in validation
@Stephen-Gates Stephen-Gates added f:Feature-request This issue is a request for a new feature fn:Validation fn:Set-Properties labels Jan 10, 2018
@Stephen-Gates Stephen-Gates added this to the v1.9.0 milestone Jan 10, 2018
@Stephen-Gates
Copy link
Contributor Author

Note this PR frictionlessdata/datapackage#588 for "no missing values".

Need to think about the UI for this

  • table vs column level
  • explaining the difference between the required constraint and no missingValues

@Stephen-Gates
Copy link
Contributor Author

/remind me on april 24 to write the acceptance test for:

@reminders reminders bot added the reminder label Mar 28, 2018
@reminders
Copy link

reminders bot commented Mar 28, 2018

@Stephen-Gates set a reminder for Apr 24th 2018

@Stephen-Gates
Copy link
Contributor Author

User interface thoughts:

Use missing values ui from Table Properties on Column Properties

screenshot 2018-04-01 11 16 05

Update tooltips to reflect if values apply to Table or Column.
Explain the Column missing values inherit from the Table values
Explain that missing value characters will be interpreted as null

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Apr 6, 2018

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Apr 7, 2018

@mattRedBox just realised that this isn't part of the spec yet or even a pattern. I can submit a PR for a pattern. I think you said tableschema.js already supports this - correct?

Proposal https://discuss.okfn.org/t/missing-values-per-field-pattern/6571

PR frictionlessdata/datapackage#608

@ghost
Copy link

ghost commented Apr 9, 2018

Hi @Stephen-Gates
They have the variable in place.
At the moment, each field/column has a reference to the table level missingValues.
We don't copy through this reference yet, but I guess once frictionless head in that direction, it will make it simpler for frictionless to refactor so that the missingValue is specific to each field. We will then need to update what we do.

@ghost
Copy link

ghost commented Apr 9, 2018

Hi @Stephen-Gates
So reading https://discuss.okfn.org/t/missing-values-per-field-pattern/6571, it reads correctly to me.

Open Knowledge Forums
Following on from Issues #551 in the specs, I’ve decided to propose a new pattern to add to the Frictionless Data Patterns. Looking forward to your feedback 😄 Missing values per field Overview Characters representing missing values in a table can be defined for all fields in a Tabular Data Resource using the missingValues property in a Table Schema. Values that match the missingValues are treated as null. The Missing values per field pattern allows different missing values to be specifie...

@reminders reminders bot removed the reminder label Apr 24, 2018
@reminders
Copy link

reminders bot commented Apr 24, 2018

👋 @Stephen-Gates, on to write the acceptance test for:

@Stephen-Gates Stephen-Gates added the status:Blocked 😢 We can't progress this until something else happens label Apr 26, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.16.0, v1.x.x, Backlog Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:Feature-request This issue is a request for a new feature fn:Set-Properties fn:Validation status:Blocked 😢 We can't progress this until something else happens
Projects
None yet
Development

No branches or pull requests

1 participant