Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotate: Rename --copyright-style to --copyright-prefix #973

Closed
carmenbianca opened this issue May 6, 2024 · 2 comments
Closed

annotate: Rename --copyright-style to --copyright-prefix #973

carmenbianca opened this issue May 6, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@carmenbianca
Copy link
Member

This is less confusing when compared to --style.

--copyright-style must still be usable. argparse.SUPPRESS can be used to hide it from reuse annotate --help.

Elsewhere in the code, the word style (when related to --copyright-style) should be renamed prefix.

See also #947 for a bigger improvement to how copyright statements are handled. Not necessarily relevant to this issue, though.
@carmenbianca carmenbianca added enhancement New feature or request good first issue Good for newcomers labels May 6, 2024
@kbroch-rivosinc
Copy link
Contributor

I'll put PR in for this. Similar to #1014

kbroch-rivosinc added a commit to kbroch-rivosinc/reuse-tool that referenced this issue Jun 29, 2024
@kbroch-rivosinc
change --copyright-style to --copyright-prefix fsfe#973
90920dd
carmenbianca pushed a commit to kbroch-rivosinc/reuse-tool that referenced this issue Jul 1, 2024
@kbroch-rivosinc @carmenbianca
change --copyright-style to --copyright-prefix fsfe#973
f2ad23f
carmenbianca pushed a commit to kbroch-rivosinc/reuse-tool that referenced this issue Jul 1, 2024
@kbroch-rivosinc @carmenbianca
change --copyright-style to --copyright-prefix fsfe#973
5937afa 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca added a commit to kbroch-rivosinc/reuse-tool that referenced this issue Jul 1, 2024
@carmenbianca
fixup! change --copyright-style to --copyright-prefix fsfe#973
1402df4 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca pushed a commit to kbroch-rivosinc/reuse-tool that referenced this issue Jul 1, 2024
@kbroch-rivosinc @carmenbianca
change --copyright-style to --copyright-prefix fsfe#973
359b1b3 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca added a commit that referenced this issue Jul 1, 2024
@carmenbianca
Merge pull request #1016 from kbroch-rivosinc/dev/kbroch/copyright-st…
6e76120 
…yle-to-copyright-prefix

change --copyright-style to --copyright-prefix #973
@carmenbianca
Copy link
Member Author

Closed by #1016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carmenbianca @kbroch-rivosinc