Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change --copyright-style to --copyright-prefix #973 #1016

Conversation

kbroch-rivosinc
Copy link
Contributor

No description provided.

@kbroch-rivosinc kbroch-rivosinc marked this pull request as draft June 29, 2024 05:05
@carmenbianca
Copy link
Member

Hi @kbroch-rivosinc ! Thanks for this PR. I will gladly wrap this up for you.

As an aside, translators tend to get angry if you manually edit the translation files. This mass edit would cause the translation 'prefix (English) → style (target language)' to become valid. Best to leave translation files alone as a rule.

@carmenbianca carmenbianca force-pushed the dev/kbroch/copyright-style-to-copyright-prefix branch 2 times, most recently from f2ad23f to dbfabbd Compare July 1, 2024 08:20
kbroch-rivosinc and others added 2 commits July 1, 2024 10:42
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca carmenbianca force-pushed the dev/kbroch/copyright-style-to-copyright-prefix branch from 1402df4 to 593bbb1 Compare July 1, 2024 08:42
@carmenbianca
Copy link
Member

Some small fixes, added a test, and ready to merge :) Thank you @kbroch-rivosinc !

@carmenbianca carmenbianca marked this pull request as ready for review July 1, 2024 08:48
@carmenbianca carmenbianca merged commit 6e76120 into fsfe:main Jul 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants