Add a set of Qt file types (pri, qrc, qss, ui) #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add few more Qt-related file extensions to known ones:
.pri: They are very closed to .pro files.
Unfortunately .pri can also refers to binary files
in Window app context, hence it is added as Uncommentable.
.qrc: Those are Qt XML files containing indexes to resource files.
Added as Uncommentable because Qt Creator IDE rewrites the file
when saving, loosing copyrights each time therefore loosing history.
.qss: Qt Style Sheet, based on CSS file format.
.ui: Qt user interface definition file, XML.
Added as Uncommentable because ui files are overwritten by
Qt Creator upon saving which looses copyright history.
Signed-off-by: Anthony Loiseau <anthony.loiseau@allcircuits.com>
|
I think it's OK to mark .pri with a comment style. I may have to double-check this, but I believe that the program checks anyway whether a given file is binary. |
As noted by Carmen Bianca BAKKER within fsfe#755 review, reuse automatically creates a .license for binary files ignoring known file extension map. Therefore binary Windows app .pri file is not an issue to mark .pri files as python-like files. I tested with two pri files: one legitimate Qt pri file (text) and one fake binary pri file. Reuse actually did things as expected, injecting license in text pri file and as a separate file for the binary pri file. Attribution: Carmen Bianca BAKKER
|
Thanks @carmenbianca for this note, you are right. Reuse header.py is_uncommentable function unconditionally returns true for files detected as binary. Therefore I updated my PR to declare Qt pri files as python-like files (as for .pro files) |
|
Thanks for the update @anthony-loiseau-act. Will merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add few more Qt-related file extensions to known ones:
.pri: They are very closed to already supported .pro files.
pri can also refers to binary files in Window app context, but this is not an issue to mark them as python-like files because reuse enforces .licence file for binary files.
.qrc: Those are Qt XML files containing indexes to resource files.
Added as Uncommentable because Qt Creator IDE rewrites the file when saving, loosing copyrights each time therefore loosing history.
.qss: Qt Style Sheet, based on CSS file format.
.ui: Qt user interface definition file, XML.
Added as Uncommentable because ui files are overwritten by Qt Creator upon saving which looses copyright history.