Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a set of Qt file types (pri, qrc, qss, ui) #755

Merged
merged 2 commits into from
Jun 6, 2023

Commits on Jun 3, 2023

  1. Add a set of Qt file types (pri, qrc, qss, ui)

    Add few more Qt-related file extensions to known ones:
    
    .pri: They are very closed to .pro files.
          Unfortunately .pri can also refers to binary files
          in Window app context, hence it is added as Uncommentable.
    
    .qrc: Those are Qt XML files containing indexes to resource files.
          Added as Uncommentable because Qt Creator IDE rewrites the file
          when saving, loosing copyrights each time therefore loosing history.
    
    .qss: Qt Style Sheet, based on CSS file format.
    
    .ui: Qt user interface definition file, XML.
         Added as Uncommentable because ui files are overwritten by
         Qt Creator upon saving which looses copyright history.
    
    Signed-off-by: Anthony Loiseau <anthony.loiseau@allcircuits.com>
    anthony-loiseau-act committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    5895f36 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. pri files can safely be commented as python files

    As noted by Carmen Bianca BAKKER within fsfe#755 review,
    reuse automatically creates a .license for binary files
    ignoring known file extension map.
    
    Therefore binary Windows app .pri file is not an issue
    to mark .pri files as python-like files.
    
    I tested with two pri files: one legitimate Qt pri file (text)
    and one fake binary pri file. Reuse actually did things as expected,
    injecting license in text pri file and as a separate file for the
    binary pri file.
    
    Attribution: Carmen Bianca BAKKER
    anthony-loiseau-act committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    10bae3d View commit details
    Browse the repository at this point in the history