Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly 0.9 #61

Closed
fsktom opened this issue Jul 27, 2023 · 6 comments
Closed

Plotly 0.9 #61

fsktom opened this issue Jul 27, 2023 · 6 comments
Assignees
Labels
cli Regarding `endsong_ui` crate dependency Waiting for a change in a dependency refactor

Comments

@fsktom
Copy link
Owner

fsktom commented Jul 27, 2023

When this gets merged and released, plotly/plotly.rs#154

Adjust

let layout = Layout::new().title(format!("<b>{title}</b>").as_str().into());

let layout = Layout::new().title(format!("<b>{title}</b>").as_str().into());

@fsktom fsktom self-assigned this Jul 27, 2023
@fsktom fsktom added refactor dependency Waiting for a change in a dependency cli Regarding `endsong_ui` crate labels Jul 27, 2023
@fsktom
Copy link
Owner Author

fsktom commented Jul 30, 2023

Added my fork to Cargo.toml temporarily for this functionality in 6e83f2b

@fsktom
Copy link
Owner Author

fsktom commented Aug 8, 2023

Seems like the guy added some more qol stuff!

fsktom added a commit that referenced this issue Aug 8, 2023
@fsktom
Copy link
Owner Author

fsktom commented Aug 8, 2023

Even better now :D
plotly/plotly.rs#154 (comment)

@fsktom fsktom changed the title Plotly 0.8.5 Plotly 0.9 Jun 25, 2024
@fsktom
Copy link
Owner Author

fsktom commented Jun 25, 2024

plotly/plotly.rs#154
it's been merged!
plotly/plotly.rs@13a8971

@fsktom
Copy link
Owner Author

fsktom commented Jul 4, 2024

fsktom added a commit that referenced this issue Jul 4, 2024
@fsktom
Copy link
Owner Author

fsktom commented Jul 4, 2024

I'll try to keep https://github.com/fsktom/plotly/tree/from alive to make those old builds reproducible. Since it's hard-linked to the git repo/branch :/

But now I can finally go back to using the crates.io version

@fsktom fsktom closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Regarding `endsong_ui` crate dependency Waiting for a change in a dependency refactor
Projects
None yet
Development

No branches or pull requests

1 participant