-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ergonomics of Title
and LegendGroupTitle
structs
#154
Conversation
This is even better! Thanks @mfreeborn :) let layout = Layout::new().title(format!("<b>{title}</b>")); is even cleaner now :D |
I'm going to go ahead and try to fix the failing examples etc. if that's alright with you |
Yes, start going for it by all means! I ran out of time updating the remaining examples etc last night. I also intend to give `LegendGroupTitle` the same treatment, which we might as well do in this PR.
…________________________________
From: Filip T ***@***.***>
Sent: Tuesday, August 8, 2023 5:48:05 PM
To: igiagkiozis/plotly ***@***.***>
Cc: Michael Freeborn ***@***.***>; Mention ***@***.***>
Subject: Re: [igiagkiozis/plotly] Add From<String> impl for Title (PR #154)
I'm going to go ahead and try to fix the failing examples etc. if that's alright with you
—
Reply to this email directly, view it on GitHub<#154 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHSVKWHCCN2XMTBK3FYCUPDXUJUULANCNFSM6AAAAAA22XQOCE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@mfreeborn I tried improving What do you think? |
Glad to see the development of this project continuing <3 Decided to sync the changes of this PR with the main branch and adjust some things. Let me know what you think |
Title
and LegendGroupTitle
structs
Seems like I missed some things... Now the clippy tests shouldn't fail |
Thanks for updating. Will have a look |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 93.61% 94.74% +1.13%
==========================================
Files 27 28 +1
Lines 7153 7283 +130
==========================================
+ Hits 6696 6900 +204
+ Misses 457 383 -74 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
@fsktom, thank you for fixing all the tests and clippy. I've just merged it. |
Thank you so much! :D |
A small quality of life improvement
So that instead of doing
I can now do