Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ergonomics of Title and LegendGroupTitle structs #154

Merged
merged 13 commits into from
Jun 25, 2024

Conversation

fsktom
Copy link
Contributor

@fsktom fsktom commented Jul 27, 2023

A small quality of life improvement

So that instead of doing

let layout = Layout::new().title(format!("<b>{title}</b>").as_str().into());

I can now do

let layout = Layout::new().title(format!("<b>{title}</b>").into());

@fsktom
Copy link
Contributor Author

fsktom commented Aug 8, 2023

This is even better! Thanks @mfreeborn :)

 let layout = Layout::new().title(format!("<b>{title}</b>"));

is even cleaner now :D

@fsktom
Copy link
Contributor Author

fsktom commented Aug 8, 2023

I'm going to go ahead and try to fix the failing examples etc. if that's alright with you

@mfreeborn
Copy link
Contributor

mfreeborn commented Aug 8, 2023 via email

@fsktom
Copy link
Contributor Author

fsktom commented Aug 9, 2023

@mfreeborn I tried improving LegendGroupTitle similarly to Title in 3feaa0c
Seemed to work fine, but I'm not sure if I did everything correctly

What do you think?

@andrei-ng andrei-ng self-assigned this Jun 12, 2024
@fsktom
Copy link
Contributor Author

fsktom commented Jun 23, 2024

Glad to see the development of this project continuing <3

Decided to sync the changes of this PR with the main branch and adjust some things. Let me know what you think

@fsktom fsktom changed the title Add From<String> impl for Title Improve ergonomics of Title and LegendGroupTitle structs Jun 23, 2024
@fsktom
Copy link
Contributor Author

fsktom commented Jun 23, 2024

Seems like I missed some things... Now the clippy tests shouldn't fail

@andrei-ng
Copy link
Collaborator

Glad to see the development of this project continuing <3

Decided to sync the changes of this PR with the main branch and adjust some things. Let me know what you think

Thanks for updating. Will have a look

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (4815df7) to head (0ea64ff).
Report is 3 commits behind head on main.

Current head 0ea64ff differs from pull request most recent head e5d03ab

Please upload reports for the commit e5d03ab to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   93.61%   94.74%   +1.13%     
==========================================
  Files          27       28       +1     
  Lines        7153     7283     +130     
==========================================
+ Hits         6696     6900     +204     
+ Misses        457      383      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
@andrei-ng andrei-ng merged commit 13a8971 into plotly:main Jun 25, 2024
18 of 19 checks passed
@andrei-ng
Copy link
Collaborator

@fsktom, thank you for fixing all the tests and clippy. I've just merged it.

@fsktom
Copy link
Contributor Author

fsktom commented Jun 25, 2024

Thank you so much! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants