Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added libdirs to fake5 doc generation. #1912

Merged
merged 1 commit into from
May 6, 2018
Merged

Conversation

kblohm
Copy link
Contributor

@kblohm kblohm commented May 5, 2018

Hi,
i forgot the libDirs for the fake5 docs. So i added them now.

@matthid
Copy link
Member

matthid commented May 5, 2018

Interesting, is there any bug at fake.build or what was the impact of this?

@kblohm
Copy link
Contributor Author

kblohm commented May 5, 2018

go to https://fake.build/apidocs/v5/fake-api-github.html
hover over createClient(user password). The signature is ... -> Async<(type)>

at https://fake.build/apidocs/v5/legacy/fake-api-github.html
it is ... -> Async<GitHubClient>
I did not see that at first because pretty much every api uses its own types and does not expose any external libraries. It might however be nice if FSFormatting would just check the folder for the dlls u specify. I doubt very many people use libraries that are not in their bin folder.

@matthid
Copy link
Member

matthid commented May 6, 2018

Thanks for clarifying and fixing. I probably missed some FSF warnings ;)

@matthid matthid changed the base branch from master to rc_11 May 6, 2018 09:20
@matthid matthid merged commit f9ed924 into fsprojects:rc_11 May 6, 2018
@kblohm kblohm deleted the fixLibDirs branch May 6, 2018 13:32
@matthid matthid mentioned this pull request May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants