Update Fake.Tools.Pickles #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmonty
force-pushed
the
Pickles
branch
4 times, most recently
from
3e25f6c to
6ebc433
Compare
|
@matthid Added unit tests and fixed the resulting bugs ;) |
|
Tried to fix on the phone but I failed :( |
matthid
requested changes
Oct 12, 2018
| let expectedPath = Path.Combine("pickles", "pickles.exe") | ||
| Expect.equal file expectedPath "Expected pickles.exe" | ||
|
|
||
| expectedPath, cp.Command.CommandLine |
There was a problem hiding this comment.
this needs to use the 'args' variable and not 'cp' in order to work with mono environments...
I think '(RawCommand(file, args)).CommandLine' should work
Can you please change the other ones as well, this should make the build green again
|
@matthid It seems now to work except for that the check for mono fails, if there are no arguments at all |
|
Ah yes, thanks for taking care of this! |
matthid
previously approved these changes
Oct 12, 2018
|
@matthid Yay, Travis is now green too ;) |
|
Yes thanks a lot :) |
This was referenced Oct 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pickles has gotten some additional command line parameters
I added them and updated the command line generation from a StringBuilder to
Args.toWindowsCommandLineTODO