Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor towards ROP #464

Closed
7 of 12 tasks
theimowski opened this issue Dec 21, 2014 · 7 comments
Closed
7 of 12 tasks

Refactor towards ROP #464

theimowski opened this issue Dec 21, 2014 · 7 comments

Comments

@theimowski
Copy link
Member

What do you guys think about employing the Railway Oriented Programming in Paket codebase?

One obvious benefit would be that in case of any failure, no file would get modified. (yeah I know one could simply git reset, but that is probably not the best UX)

A command-line tool seems like a good candidate for the ROP technique.
As a volunteer I could do an experiment with the commands I'm most familiar with, i.e. convert-from-nuget and simplify to see where we can get to.

Edit:
List of paket commands that use ROP:

  • Init
  • Add
  • Remove
  • Install
  • Restore
  • Update
  • Outdated
  • ConvertFromNuget
  • InitAutoRestore
  • Simplify
  • FindRefs
  • Config
@isaacabraham
Copy link
Contributor

I'm using that approach on another project with a lot of success. It works well when there's a clear, linear pipeline of operations.

@forki
Copy link
Member

forki commented Dec 21, 2014

I have no objections ;-)

@forki
Copy link
Member

forki commented Jan 5, 2015

are you going to refactor other commands as well?

@theimowski
Copy link
Member Author

I plan to, but surely it can take more time.
Applying ROP gradually (i.e. not in a single PR) to the commands should be less error-prone

@forki
Copy link
Member

forki commented Jan 5, 2015

+1

theimowski added a commit to theimowski/Paket that referenced this issue Jan 6, 2015
forki added a commit that referenced this issue Jan 7, 2015
Raise exception when a train arrives on Failure rails - references #464
This was referenced Jan 7, 2015
@forki
Copy link
Member

forki commented Jan 7, 2015

I wonder what Scott Wlashin is thinking about this!? It's becoming probably the biggest OSS project on ROP.

@theimowski
Copy link
Member Author

yeah, it'd be great if he could review the stuff one day when more commands use ROP, and tell whether that's what he meant 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants