Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rop init & init auto restore command #533

Merged
merged 7 commits into from
Jan 9, 2015

Conversation

theimowski
Copy link
Member

actually init is so simple, there's no failure track for now
references #464

|> collect

let projectsUnderPaket =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't the projects already in environment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot! I totally forgot about it

DependenciesFile(
Path.Combine(directory.FullName, Constants.DependenciesFileName),
InstallOptions.Default, [], [], [])
dependenciesFile.Save()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this Save call can fail. For example insufficient rights to create a file.

@forki
Copy link
Member

forki commented Jan 9, 2015

please add a :shipit: when you are ready.

@theimowski
Copy link
Member Author

:shipit: !

forki added a commit that referenced this pull request Jan 9, 2015
Rop init & init auto restore command
@forki forki merged commit 18654a3 into fsprojects:master Jan 9, 2015
@theimowski theimowski deleted the rop_init_command branch January 9, 2015 17:07
@forki
Copy link
Member

forki commented Jan 9, 2015

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants