Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serializing stopped jails #53

Closed
wants to merge 1 commit into from
Closed

Conversation

joritkm
Copy link
Collaborator

@joritkm joritkm commented Mar 12, 2019

This addresses #2 and enables serializing a stopped jail.

Requires serialization support in fubarnetes/rctl

Serialization is This could also be made optional via feature-flags.

@joritkm joritkm added do-not-merge dependencies Pull requests that update a dependency file labels Mar 12, 2019
@joritkm joritkm requested a review from fabianfreyer March 12, 2019 19:50
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #53 into dev will increase coverage by 6.39%.
The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #53      +/-   ##
==========================================
+ Coverage   33.64%   40.03%   +6.39%     
==========================================
  Files           8        8              
  Lines         541      577      +36     
==========================================
+ Hits          182      231      +49     
+ Misses        359      346      -13
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (+100%) ⬆️
src/stopped.rs 34.4% <100%> (+34.4%) ⬆️
src/param.rs 37.44% <100%> (+0.27%) ⬆️
src/tests.rs 58% <62.5%> (+4.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ea022...905b78d. Read the comment docs.

Copy link
Contributor

@fabianfreyer fabianfreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

use joppich/rctl:serialize as source for rctl

make serialization opt-in via feature-flag

update ci configuration to run cargo builds and tests with `--all-features`-flag
@fabianfreyer
Copy link
Contributor

Merged in 934505d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants