Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement serialization feature-flag #6

Merged
merged 1 commit into from
Mar 30, 2019
Merged

implement serialization feature-flag #6

merged 1 commit into from
Mar 30, 2019

Conversation

joritkm
Copy link

@joritkm joritkm commented Mar 12, 2019

This enables serialization for the following rctl structs:

  • User
  • Process
  • Jail
  • LoginClass

and these enums:

  • Subject
  • SubjectType
  • Resource
  • Action

It's implemented as a feature and can be enabled with

$ cargo build --features=serialize

@joritkm joritkm mentioned this pull request Mar 12, 2019
Closed
@fabianfreyer
Copy link
Contributor

This is pretty nice, but I'm not 100% sure it might not just be worth using the native string representations:
https://github.com/fubarnetes/rctl/blob/master/src/lib.rs#L1181-L1221

@fabianfreyer fabianfreyer self-requested a review March 22, 2019 00:23
@fabianfreyer fabianfreyer added the enhancement New feature or request label Mar 22, 2019
@fabianfreyer fabianfreyer merged commit 825fb54 into fubarnetes:master Mar 30, 2019
@joritkm joritkm deleted the serialize branch March 30, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfreyer fabianfreyer fabianfreyer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joritkm @fabianfreyer