Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 꿀조합에 사용된 상품 정보에 상품 이미지 URL 추가 #27

Merged
merged 7 commits into from
Apr 3, 2024
Merged

refactor: 꿀조합에 사용된 상품 정보에 상품 이미지 URL 추가 #27

merged 7 commits into from
Apr 3, 2024

Conversation

70825
Copy link
Member

@70825 70825 commented Mar 27, 2024 •
edited
Loading

Issue

✨ 구현한 기능

image

  • 꿀조합에 사용된 상품들의 이미지 URL을 추가했습니다.

    • 하리보 짜파게티 → 하리보 상품 사진 경로, 짜파게티 상품 사진 경로를 가지고 있음

  • 새로 DTO를 만들어서 작업 했습니다.

    • 기존 상품 정보 DTO가 쓰이는 곳
      • 꿀조합 검색
      • 상품에서 볼 수 있는 꿀조합
      • 레시피 목록
      • 레시피 상세 정보 (이 부분을 새로운 DTO로 수정)

📢 논의하고 싶은 내용

.

🎸 기타

  • 노션 문서 수정 완료 (레시피 상세 조회)

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 1

@70825 70825 self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit d2e4054. ± Comparison against base commit 2f712af.

♻️ This comment has been updated with latest results.

@70825 70825 mentioned this pull request Mar 27, 2024
Merged
Go-Jaecheol
Go-Jaecheol requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
코멘트 2개 남겨놨으니 확인해주세요~~

src/main/java/com/funeat/recipe/dto/DetailProductRecipeDto.java Outdated Show resolved Hide resolved
src/test/java/com/funeat/acceptance/recipe/RecipeAcceptanceTest.java Outdated Show resolved Hide resolved
@70825 70825 requested a review from Go-Jaecheol April 2, 2024 10:27
@70825 70825 force-pushed the refactor/issue-26 branch 15 times, most recently from 152c92d to 70d364d Compare April 2, 2024 14:45
@70825 70825 force-pushed the refactor/issue-26 branch 6 times, most recently from 198bcd6 to 8686231 Compare April 2, 2024 15:44
@70825 70825 merged commit 255f868 into develop Apr 3, 2024
2 of 3 checks passed
@70825 70825 deleted the refactor/issue-26 branch April 3, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wugawuga wugawuga wugawuga approved these changes

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

Assignees

@70825 70825

Labels
🔧 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

꿀조합에 사용된 상품 이미지 추가
3 participants
@70825 @Go-Jaecheol @wugawuga