Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 상품 상세 정보에 카테고리 정보 추가 #29

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

70825
Copy link
Member

@70825 70825 commented Mar 27, 2024

Issue

✨ 구현한 기능

image

  • 위에 어느 편의점 상품인지 확인할 수 있도록 카테고리 정보를 추가했습니다.

  • Category에 대한 DTO가 CategoryResponse만 존재해서 CategoryDto를 만들었습니다.

📢 논의하고 싶은 내용

.

🎸 기타

  • 노션 문서 수정 완료 (상품 상세 정보 조회)

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 0.25

@70825 70825 self-assigned this Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7b81817.

♻️ This comment has been updated with latest results.

@70825 70825 force-pushed the refactor/issue-28 branch 2 times, most recently from 468fb18 to 50dc06e Compare March 27, 2024 14:47
@70825
Copy link
Member Author

70825 commented Mar 27, 2024

리뷰 목록을 최신순으로 정렬하는 곳에서 에러가 발생하는데, #27 에 관련된 코드가 있어서 저거 먼저 머지되면 다시 테스트 해볼게요

Copy link
Contributor

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿👍👍 고생하셨슴다

@70825 70825 merged commit fa646ae into develop Apr 3, 2024
2 of 3 checks passed
@70825 70825 deleted the refactor/issue-28 branch April 3, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

상품 상세 요청에 편의점 카테고리 정보 추가
2 participants