Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm install #60

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Fix npm install #60

merged 6 commits into from
Feb 27, 2023

Conversation

343dev
Copy link
Contributor

@343dev 343dev commented Feb 22, 2023 •
edited
Loading

npm does not run npm install for dependencies included with local path.

The npm team proposed an RFC to fix this issue: npm/rfcs#150

@343dev 343dev self-assigned this Feb 22, 2023
@343dev 343dev requested a review from igoradamenko February 22, 2023 17:53
@343dev 343dev linked an issue Feb 22, 2023 that may be closed by this pull request
Failure to install from version 4.1.0 #59
Closed
@343dev 343dev marked this pull request as draft February 22, 2023 17:59
@343dev 343dev force-pushed the bugfix/npm-install branch from 41bdfd1 to 9b72aa4 Compare February 22, 2023 18:50
@343dev
Copy link
Contributor Author

343dev commented Feb 22, 2023

https://hub.docker.com/layers/343dev/optimizt/4.1.1/images/sha256-5bf013357c9e1bfaa88e59ccd41966ce869226d9784227d43764e07b18bfc55a?context=explore

@343dev 343dev marked this pull request as ready for review February 22, 2023 19:06
@igoradamenko igoradamenko merged commit 479732f into master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoradamenko igoradamenko Awaiting requested review from igoradamenko

Assignees

@343dev 343dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to install from version 4.1.0
2 participants
@343dev @igoradamenko