-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add file+pack dependency protocol #150
base: main
Are you sure you want to change the base?
Conversation
@RecuencoJones quick note/update, we'll be discussing this in our Open RFC call today & will leave it on the agenda if you aren't able to join this week (ref: #166). |
Already joined @darcyclarke 😄 |
Quick update as per yesterday's Open RFC Meeting, looks like Arborist already supports running prepack scripts for some protocols (i.e, This is true with just one caveat, if prepack script requires any binaries from devDependencies it will require an explicit npm install before running any other scripts! git+https prepackGiven the following package JSON: We could then depend on it as:
With the following error log when running npm debug log
TL;DR: git+https prepack with explicit installGiven the following package JSON: We could then depend on it as:
Which would then run it's prepack script, installing git-pack dependencies, building, packing as tarball and eventually installing the tarball. npm debug log (npm install)
npm debug log (npm install --only=dev)
The contents from node_modules then are:
This is exactly what would be expected if we installed the package from the registry! git+file?It was suggested that git+file should do the same and have been able to test with a similar setup:
Where
First thing to note is that it requires a full path to the repo! Otherwise it fails with:
Because of that and because git is not able to manage repos inside repos without submodules, we would rather use git+https instead 😄 Also, running npm debug log
configuration for packing file repositoriesIt was then suggested that we could have some setting in This raises a question, would this setting apply for all It could be some setting like |
From discussion:
|
@darcyclarke @ruyadorno will this be part of Aug 12th Open RFC Meeting? |
What / Why
Imported from npm/cli#1333
Add a way to install local folder dependencies by first running
pack
script to trigger any build process required to generate distributable files before linking generated tarball to requesting module.References