Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error message when wrong frame is provided #120

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

JoOkuma
Copy link
Contributor

@JoOkuma JoOkuma commented Aug 30, 2024

Hi @cmalinmayor,

We had some issues with this, and some users found it challenging to debug during the project week.

I noticed this is checked in add_nodes but not when creating from networkx.

LMK if you have any additional suggestions.

@cmalinmayor
Copy link
Contributor

Thanks Jordao! This was on the TODO list (#91) but I never got around to it. I'll leave #91 open because I think we had plans to do something a bit more sophisticated around checking hyperedges, but this will be very helpful in the meantime!

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (4d14bd6) to head (d445bc1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
motile/track_graph.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   93.02%   92.92%   -0.11%     
==========================================
  Files          30       30              
  Lines         717      721       +4     
==========================================
+ Hits          667      670       +3     
- Misses         50       51       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor
Copy link
Contributor

I'll look into the docs failing - I presume it has nothing to do with the actual change.

@cmalinmayor cmalinmayor merged commit ba6e4f5 into funkelab:main Sep 26, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants