Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Attachments #19

Merged
merged 52 commits into from
Oct 4, 2018
Merged

File Attachments #19

merged 52 commits into from
Oct 4, 2018

Conversation

creecros
Copy link
Collaborator

@creecros creecros commented Oct 3, 2018

All Submissions:

  • Have you updated the ChangeLog with your proposed changes?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you updated the getPluginVersion() in Plugin.php and Makefile version appropriately?

New Feature Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

Description

Fixes #3 .

Changes proposed in this pull request:

  • I made your file attachments work. Your schema for sqlite and postgress seems iffy, but I was using sqlite in testing and it still worked, maybe take a look at that.

@creecros
Copy link
Collaborator Author

creecros commented Oct 4, 2018

Oh, FYI, I stayed clear of fireCreationEvent, that was a rabbit hole I wasn't prepared to go down. I can come back to it later if needed.

@lastlink lastlink merged commit 0718548 into funktechno:master Oct 4, 2018
@lastlink
Copy link
Contributor

lastlink commented Oct 4, 2018

The migrations for postgres are incorrect w/ the wrong table named and the slide show won't change past the first image. I have the fix for postgres, I'll see about the work to fix the slideshow. I tested it on all 3 dbs supported.

@creecros
Copy link
Collaborator Author

creecros commented Oct 4, 2018

I'll take a look tonight on the slideshow

@lastlink lastlink mentioned this pull request Oct 5, 2018
1 task
@creecros creecros mentioned this pull request Oct 5, 2018
4 tasks
@creecros
Copy link
Collaborator Author

creecros commented Oct 5, 2018

looks like you beat me to the postgres, should still merge ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants