-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #21
Merged
Merged
Patch 1 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think I'll get to this for about a week b/c of time. I did merge, update the other parts of the plugin, and do a release which is now available. I think that going a week or 2 without the working slideshow should be fine. Thanks for your help. |
No worries, sorry I didn't notice that earlier |
lastlink
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Description
Fixes #19 .
Changes proposed in this pull request:
Seems to work now, updated postgress as well. I am noticing that each image creates a slideshow and the cache doesn't clear, so if you close a slideshow, and then click reopen, it picks off where you left off for each image slideshow. I tried to problem solve, but then tested the current slide show for tasks, and it performed the sameway, so either it's just me or that just how they all work.