Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #21

Merged
merged 17 commits into from
Nov 14, 2018
Merged

Patch 1 #21

merged 17 commits into from
Nov 14, 2018

Conversation

creecros
Copy link
Collaborator

@creecros creecros commented Oct 5, 2018

All Submissions:

  • Have you updated the ChangeLog with your proposed changes?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you updated the getPluginVersion() in Plugin.php and Makefile version appropriately?

New Feature Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

Description

Fixes #19 .

Changes proposed in this pull request:

Seems to work now, updated postgress as well. I am noticing that each image creates a slideshow and the cache doesn't clear, so if you close a slideshow, and then click reopen, it picks off where you left off for each image slideshow. I tried to problem solve, but then tested the current slide show for tasks, and it performed the sameway, so either it's just me or that just how they all work.

@lastlink
Copy link
Contributor

lastlink commented Oct 5, 2018

I don't think I'll get to this for about a week b/c of time. I did merge, update the other parts of the plugin, and do a release which is now available. I think that going a week or 2 without the working slideshow should be fine. Thanks for your help.

@creecros
Copy link
Collaborator Author

creecros commented Oct 5, 2018

No worries, sorry I didn't notice that earlier

@lastlink lastlink merged commit 01f716f into funktechno:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants