-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trivy from 0.35.0 to 0.49.1 #1806
Conversation
fe33770
to
996c7b8
Compare
9e4eb64
to
7be4469
Compare
90fc42b
to
4886ab1
Compare
fa860e3
to
6633b81
Compare
Co-authored-by: MaineK00n <mainek00n.1229@gmail.com>
Co-authored-by: MaineK00n <mainek00n.1229@gmail.com>
Co-authored-by: MaineK00n <mainek00n.1229@gmail.com>
Co-authored-by: MaineK00n <mainek00n.1229@gmail.com>
Co-authored-by: MaineK00n <mainek00n.1229@gmail.com>
506c517
to
0e752b0
Compare
manual test result for jar/war
|
manual test result for dart/pub
|
manual test result for elixir/mix
|
manual test result for rust/binary
|
manual test result for swift/cocoapods
|
manual test result for swift/swift
|
Above manual tests are done with integration at the commit vulsio/integration@b91ccaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉
What did you implement:
Update Trivy dependency 0.35.0 -> 0.49.1
Type of change
Main change is only updating trivy 0.35.0 to 0.49.1 in
go.mod
.Other changes in
go.mod
and every change ingo.sum
are not by human beings.Due to this, type puzzles forced some other code changes.
One internal but (maybe) important change is that trivy introduces "post analyzer" concept.
It uses temp directories and temp files so vuls follows the way and create them.
The trivy update enables vuls to use additional language scanners:
pubspec.lock
is auto-detectedmix.lock
is auto-detectedPodfile.lock
is auto-detectedPackage.resolved
is auto-detectedTrivy's java/jar logic uses Java DB and it is heavy (~ 600MB).
This PR does NOT download it at scan phase but does at detect phase.
So, following options are added to
vuls report
command:-trivy-java-db-repository
-trivy-skip-java-db-update
Also includes small bug fixes:
How Has This Been Tested?
By hand.
Checklist:
make fmt
make test
Reference
https://aquasecurity.github.io/trivy/v0.49/docs/vulnerability/db/#java-index-database
https://aquasecurity.github.io/trivy/v0.49/docs/vulnerability/examples/db/#java-vulnerability-db
https://aquasecurity.github.io/trivy/v0.49/docs/advanced/air-gap/
Add some language libarary tests (along with trivy update 0.49.1) vulsio/integration#12
Changes for Trivy update vulsdoc/vuls#240