-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PackageURL):add package URL for library scan result #1862
Merged
shino
merged 15 commits into
future-architect:master
from
TsubasaKanemitsu:packageurl-library
Mar 7, 2024
Merged
feat(PackageURL):add package URL for library scan result #1862
shino
merged 15 commits into
future-architect:master
from
TsubasaKanemitsu:packageurl-library
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsubasaKanemitsu
changed the title
feat(PackageURL):add packagge URL for library scan result
[WIP] feat(PackageURL):add packagge URL for library scan result
Mar 5, 2024
TsubasaKanemitsu
changed the title
[WIP] feat(PackageURL):add packagge URL for library scan result
[WIP] feat(PackageURL):add package URL for library scan result
Mar 6, 2024
TsubasaKanemitsu
changed the title
[WIP] feat(PackageURL):add package URL for library scan result
feat(PackageURL):add package URL for library scan result
Mar 6, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
requested changes
Mar 7, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
requested changes
Mar 7, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
reviewed
Mar 7, 2024
MaineK00n
approved these changes
Mar 7, 2024
shino
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
We have updated the version of Trivy used in Vuls to 0.49.1.
As a result, the results of filesystem scan and container image scan now include a Package URL.
Therefore, we will also include Package URL in the results of trivy-to-vuls and lockfile scan.
Type of change
How Has This Been Tested?
Manually.
trivy-to-vuls
Parse file system scan result
$ trivy -q fs -f json poetry.lock --list-all-pkgs | CGO_ENABLED=0 go run contrib/trivy/cmd/main.go parse --stdin
The PackageURL does not exist in the libraries.Libs.
before
The PackageURL is added inside the libraries.Libs.
after
Parse container image scan result
$ trivy -q image -f=json python:3.4-alpine --list-all-pkgs | CGO_ENABLED=0 go run contrib/trivy/cmd/main.go parse --stdin
The PackageURL does not exist in the libraries.Libs.
before
The PackageURL has been added inside the libraries.Libs.
after
Lockfile Scan
config.toml
The PackageURL does not exist in the libraries.Libs.
before
The PackageURL has been added inside the libraries.Libs.
after
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference