This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
en_GB localization #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that GB-style postcodes containing letters can be used
| @@ -81,7 +81,7 @@ class Address extends \Faker\Provider\Base | |||
| */ | |||
| public static function postcode() | |||
| { | |||
| return static::numerify(static::randomElement(static::$postcode)); | |||
| return strtoupper(static::bothify(static::randomElement(static::$postcode))); | |||
There was a problem hiding this comment.
To add flexibility to allow postcodes such as AB12 3CD but still parse US zip codes
|
Awesome! Thanks for the PR. |
mgriffin
pushed a commit
to mgriffin/Faker
that referenced
this pull request
Feb 19, 2014
en_GB localization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
en_GB localization, appears to work well, still needs tests written.