Support isize (mimic existing usize)
#1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait: shekohex/allo-isolate#53 |
|
This issue reminds me of |
|
@dbsxdbsx Ah yes, feel free to PR! (As I have probably said before, just |
This reverts commit f1a4a3295cb09dd3eee57097d9b2f0ddad83d23b.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 99.20% 99.22% +0.02%
==========================================
Files 341 341
Lines 13230 13230
==========================================
+ Hits 13125 13128 +3
+ Misses 105 102 -3 ☔ View full report in Codecov by Sentry. |
fzyzcjy
force-pushed
the
master
branch
3 times, most recently
from
2e0e4d5
to
408fcfb
Compare
# Conflicts: # frb_example/pure_dart/frb_generated.h # frb_example/pure_dart/rust/src/frb_generated.io.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please list issues fixed by this PR here, using format "Fixes #the-issue-number".
Checklist
./frb_example/pure_dartexample, more specifically,rust/src/api/whatever.rsandtest/api/whatever_test.dart../frb_internal precommit --mode slow(orfast) is run (it internal runs code generator, does auto formatting, etc)../websitefolder) are updated../frb_internal somethingcommands shown in CI.)Remark for PR creator
./frb_internal --helpshows utilities for development.